PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Use (props,state) ordering of arguments

Browse source 
There was a bug here that meant that sometimes arguments were given in the wrong order; presumably leading to the status bar not appearing for calls etc.
This commit is contained in:
Luke Barnard 2017-02-09 10:01:59 +00:00
parent cc69e982a7
commit 553054409f
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/components/structures/RoomStatusBar.js
View file

@ -103,7 +103,7 @@ module.exports = React.createClass({
this.props.onResize(); this.props.onResize();
} }
const size = this._getSize(this.state, this.props); const size = this._getSize(this.props, this.state);
if (size > 0) { if (size > 0) {
this.props.onVisible(); this.props.onVisible();
} else { } else {
@ -145,7 +145,7 @@ module.exports = React.createClass({
// We don't need the actual height - just whether it is likely to have // We don't need the actual height - just whether it is likely to have
// changed - so we use '0' to indicate normal size, and other values to // changed - so we use '0' to indicate normal size, and other values to
// indicate other sizes. // indicate other sizes.
_getSize: function(state, props) { _getSize: function(props, state) {
if (state.syncState === "ERROR" || if (state.syncState === "ERROR" ||
(state.usersTyping.length > 0) || (state.usersTyping.length > 0) ||
props.numUnreadMessages || props.numUnreadMessages ||
@ -163,7 +163,8 @@ module.exports = React.createClass({
// determine if we need to call onResize // determine if we need to call onResize
_checkForResize: function(prevProps, prevState) { _checkForResize: function(prevProps, prevState) {
// figure out the old height and the new height of the status bar. // figure out the old height and the new height of the status bar.
return this._getSize(prevProps, prevState) !== this._getSize(this.props, this.state); return this._getSize(prevProps, prevState)
!== this._getSize(this.props, this.state);
}, },
// return suitable content for the image on the left of the status bar. // return suitable content for the image on the left of the status bar.