PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Merge pull request #5049 from matrix-org/travis/perf5

Browse source 
Ensure notification badges stop listening when they unmount
This commit is contained in:
Travis Ralston 2020-07-24 14:08:28 -06:00 committed by GitHub
commit 548b8adb66
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/components/views/rooms/NotificationBadge.tsx
View file

@ -72,6 +72,7 @@ export default class NotificationBadge extends React.PureComponent<XOR<IProps, I
public componentWillUnmount() { public componentWillUnmount() {
SettingsStore.unwatchSetting(this.countWatcherRef); SettingsStore.unwatchSetting(this.countWatcherRef);
this.props.notification.off(NOTIFICATION_STATE_UPDATE, this.onNotificationUpdate);
} }
public componentDidUpdate(prevProps: Readonly<IProps>) { public componentDidUpdate(prevProps: Readonly<IProps>) {