PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Quick settings: Change the copy / labels on the options (#10427)

Browse source 
* Quick settings: Change the copy / labels on the options
* Update i18n
This commit is contained in:
Janne Mareike Koschinski 2023-04-04 21:00:57 +02:00 committed by GitHub
parent a340387374
commit 52eec283b3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cypress/e2e/sliding-sync/sliding-sync.ts
View file

@ -202,7 +202,7 @@ describe("Sliding Sync", () => {
// disable notifs in this room (TODO: CS API call?) // disable notifs in this room (TODO: CS API call?)
cy.contains(".mx_RoomTile", "Test Room").find(".mx_RoomTile_notificationsButton").click({ force: true }); cy.contains(".mx_RoomTile", "Test Room").find(".mx_RoomTile_notificationsButton").click({ force: true });
cy.contains("Off").click(); cy.contains("Mute room").click();
// create a new room so we know when the message has been received as it'll re-shuffle the room list // create a new room so we know when the message has been received as it'll re-shuffle the room list
cy.createRoom({ cy.createRoom({

6
src/components/views/context_menus/RoomNotificationContextMenu.tsx
View file

@ -52,7 +52,7 @@ export const RoomNotificationContextMenu: React.FC<IProps> = ({ room, onFinished
const defaultOption: JSX.Element = ( const defaultOption: JSX.Element = (
<IconizedContextMenuRadio <IconizedContextMenuRadio
label={_t("Use default")} label={_t("Match default setting")}
active={notificationState === RoomNotifState.AllMessages} active={notificationState === RoomNotifState.AllMessages}
iconClassName="mx_RoomNotificationContextMenu_iconBell" iconClassName="mx_RoomNotificationContextMenu_iconBell"
onClick={wrapHandler(() => setNotificationState(RoomNotifState.AllMessages))} onClick={wrapHandler(() => setNotificationState(RoomNotifState.AllMessages))}
@ -70,7 +70,7 @@ export const RoomNotificationContextMenu: React.FC<IProps> = ({ room, onFinished
const mentionsOption: JSX.Element = ( const mentionsOption: JSX.Element = (
<IconizedContextMenuRadio <IconizedContextMenuRadio
label={_t("Mentions & Keywords")} label={_t("Mentions & keywords")}
active={notificationState === RoomNotifState.MentionsOnly} active={notificationState === RoomNotifState.MentionsOnly}
iconClassName="mx_RoomNotificationContextMenu_iconBellMentions" iconClassName="mx_RoomNotificationContextMenu_iconBellMentions"
onClick={wrapHandler(() => setNotificationState(RoomNotifState.MentionsOnly))} onClick={wrapHandler(() => setNotificationState(RoomNotifState.MentionsOnly))}
@ -79,7 +79,7 @@ export const RoomNotificationContextMenu: React.FC<IProps> = ({ room, onFinished
const muteOption: JSX.Element = ( const muteOption: JSX.Element = (
<IconizedContextMenuRadio <IconizedContextMenuRadio
label={_t("Off")} label={_t("Mute room")}
active={notificationState === RoomNotifState.Mute} active={notificationState === RoomNotifState.Mute}
iconClassName="mx_RoomNotificationContextMenu_iconBellCrossed" iconClassName="mx_RoomNotificationContextMenu_iconBellCrossed"
onClick={wrapHandler(() => setNotificationState(RoomNotifState.Mute))} onClick={wrapHandler(() => setNotificationState(RoomNotifState.Mute))}

4
src/i18n/strings/en_EN.json
View file

@ -3255,8 +3255,8 @@
"Low Priority": "Low Priority", "Low Priority": "Low Priority",
"Forget Room": "Forget Room", "Forget Room": "Forget Room",
"Mark as read": "Mark as read", "Mark as read": "Mark as read",
"Use default": "Use default", "Match default setting": "Match default setting",
"Mentions & Keywords": "Mentions & Keywords", "Mute room": "Mute room",
"See room timeline (devtools)": "See room timeline (devtools)", "See room timeline (devtools)": "See room timeline (devtools)",
"Space": "Space", "Space": "Space",
"Space home": "Space home", "Space home": "Space home",