Merge pull request #3468 from matrix-org/bwindels/cider-autocomplete-fixes

Fix: when using autocomplete, ensure command is not sent as text, and @room notifs gets needed suffix

src/autocomplete/CommandProvider.js

@@ -64,6 +64,7 @@ export default class CommandProvider extends AutocompleteProvider {
         return matches.map((result) => ({
             // If the command is the same as the one they entered, we don't want to discard their arguments
             completion: result.command === command[1] ? command[0] : (result.command + ' '),
+            type: "command",
             component: <TextualCompletion
                 title={result.command}
                 subtitle={result.args}

src/autocomplete/CommunityProvider.js

@@ -84,6 +84,7 @@ export default class CommunityProvider extends AutocompleteProvider {
             ]).map(({avatarUrl, groupId, name}) => ({
                 completion: groupId,
                 suffix: ' ',
+                type: "community",
                 href: makeGroupPermalink(groupId),
                 component: (
                     <PillCompletion initialComponent={

src/autocomplete/NotifProvider.js

@@ -42,6 +42,7 @@ export default class NotifProvider extends AutocompleteProvider {
             return [{
                 completion: '@room',
                 completionId: '@room',
+                type: "at-room",
                 suffix: ' ',
                 component: (
                     <PillCompletion initialComponent={<RoomAvatar width={24} height={24} room={this.room} />} title="@room" description={_t("Notify the whole room")} />

src/autocomplete/RoomProvider.js

@@ -89,6 +89,7 @@ export default class RoomProvider extends AutocompleteProvider {
                 return {
                     completion: displayAlias,
                     completionId: displayAlias,
+                    type: "room",
                     suffix: ' ',
                     href: makeRoomPermalink(displayAlias),
                     component: (

src/autocomplete/UserProvider.js

@@ -114,6 +114,7 @@ export default class UserProvider extends AutocompleteProvider {
                     // relies on the length of the entity === length of the text in the decoration.
                     completion: user.rawDisplayName,
                     completionId: user.userId,
+                    type: "user",
                     suffix: (selection.beginning && range.start === 0) ? ': ' : ' ',
                     href: makeUserPermalink(user.userId),
                     component: (

src/editor/autocomplete.js

@@ -100,19 +100,21 @@ export default class AutocompleteWrapperModel {
     _partForCompletion(completion) {
         const {completionId} = completion;
         const text = completion.completion;
-        const firstChr = completionId && completionId[0];
-        switch (firstChr) {
-            case "@": {
-                if (completionId === "@room") {
-                    return [this._partCreator.atRoomPill(completionId)];
-                } else {
-                    return this._partCreator.createMentionParts(this._partIndex, text, completionId);
-                }
-            }
-            case "#":
-                return [this._partCreator.roomPill(completionId)];
-            // used for emoji and command completion replacement
+        switch (completion.type) {
+            case "room":
+                return [this._partCreator.roomPill(completionId), this._partCreator.plain(completion.suffix)];
+            case "at-room":
+                return [this._partCreator.atRoomPill(completionId), this._partCreator.plain(completion.suffix)];
+            case "user":
+                // not using suffix here, because we also need to calculate
+                // the suffix when clicking a display name to insert a mention,
+                // which happens in createMentionParts
+                return this._partCreator.createMentionParts(this._partIndex, text, completionId);
+            case "command":
+                // command needs special handling for auto complete, but also renders as plain texts
+                return [this._partCreator.command(text)];
             default:
+                // used for emoji and other plain text completion replacement
                 return [this._partCreator.plain(text)];
         }
     }

src/editor/parts.js

@@ -456,15 +456,20 @@ export class CommandPartCreator extends PartCreator {
     createPartForInput(text, partIndex) {
         // at beginning and starts with /? create
         if (partIndex === 0 && text[0] === "/") {
-            return new CommandPart("", this._autoCompleteCreator);
+            // text will be inserted by model, so pass empty string
+            return this.command("");
         } else {
             return super.createPartForInput(text, partIndex);
         }
     }
 
+    command(text) {
+        return new CommandPart(text, this._autoCompleteCreator);
+    }
+
     deserializePart(part) {
         if (part.type === "command") {
-            return new CommandPart(part.text, this._autoCompleteCreator);
+            return this.command(part.text);
         } else {
             return super.deserializePart(part);
         }