Iterate PR based on feedback
This commit is contained in:
parent
1ff870927a
commit
42a3ace82a
2 changed files with 5 additions and 7 deletions
|
@ -31,7 +31,7 @@ interface IProps {
|
|||
* Component which shows the global notification list using a TimelinePanel
|
||||
*/
|
||||
@replaceableComponent("structures.NotificationPanel")
|
||||
class NotificationPanel extends React.Component<IProps> {
|
||||
export default class NotificationPanel extends React.PureComponent<IProps> {
|
||||
render() {
|
||||
const emptyState = (<div className="mx_RightPanel_empty mx_NotificationPanel_empty">
|
||||
<h2>{_t('You’re all caught up')}</h2>
|
||||
|
@ -62,5 +62,3 @@ class NotificationPanel extends React.Component<IProps> {
|
|||
</BaseCard>;
|
||||
}
|
||||
}
|
||||
|
||||
export default NotificationPanel;
|
||||
|
|
|
@ -295,13 +295,13 @@ export default class RightPanel extends React.Component<IProps, IState> {
|
|||
break;
|
||||
|
||||
case RightPanelPhases.NotificationPanel:
|
||||
if (SettingsStore.getValue("feature_pinning")) {
|
||||
panel = <NotificationPanel onClose={this.onClose} />;
|
||||
}
|
||||
panel = <NotificationPanel onClose={this.onClose} />;
|
||||
break;
|
||||
|
||||
case RightPanelPhases.PinnedMessages:
|
||||
panel = <PinnedMessagesCard room={this.props.room} onClose={this.onClose} />;
|
||||
if (SettingsStore.getValue("feature_pinning")) {
|
||||
panel = <PinnedMessagesCard room={this.props.room} onClose={this.onClose} />;
|
||||
}
|
||||
break;
|
||||
|
||||
case RightPanelPhases.FilePanel:
|
||||
|
|
Loading…
Reference in a new issue