From 3c8ac6fc492feec325b781b4b80fe2e71b71b83a Mon Sep 17 00:00:00 2001 From: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Date: Mon, 21 Oct 2024 18:45:01 +0100 Subject: [PATCH] playwright: remove flaky check (#28260) This sometimes happens too quickly for us to test. Fixes: #27585 --- playwright/e2e/crypto/crypto.spec.ts | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/playwright/e2e/crypto/crypto.spec.ts b/playwright/e2e/crypto/crypto.spec.ts index e3285b898d..2ab49e72ec 100644 --- a/playwright/e2e/crypto/crypto.spec.ts +++ b/playwright/e2e/crypto/crypto.spec.ts @@ -114,13 +114,10 @@ test.describe("Cryptography", function () { await dialog.getByRole("button", { name: "Continue" }).click(); await copyAndContinue(page); - // When the device is verified, the `Setting up keys` step is skipped - if (!isDeviceVerified) { - const uiaDialogTitle = page.locator(".mx_InteractiveAuthDialog .mx_Dialog_title"); - await expect(uiaDialogTitle.getByText("Setting up keys")).toBeVisible(); - await expect(uiaDialogTitle.getByText("Setting up keys")).not.toBeVisible(); - } + // If the device is unverified, there should be a "Setting up keys" step; however, it + // can be quite quick, and playwright can miss it, so we can't test for it. + // Either way, we end up at a success dialog: await expect(dialog.getByText("Secure Backup successful")).toBeVisible(); await dialog.getByRole("button", { name: "Done" }).click(); await expect(dialog.getByText("Secure Backup successful")).not.toBeVisible();