PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Enable strictNullChecks and noImplicitAny (#11194)

Browse source
This commit is contained in:
Michael Telatynski 2023-07-06 14:59:47 +01:00 committed by GitHub
parent b467d0700f
commit 3c81f30c26
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/components/views/dialogs/BaseDialog.tsx
View file

@ -94,7 +94,11 @@ export default class BaseDialog extends React.Component<IProps> {
public constructor(props: IProps) {
super(props);
this.matrixClient = MatrixClientPeg.get();
// XXX: The contract on MatrixClientContext says it is only available within a LoggedInView subtree,
// given that modals function outside the MatrixChat React tree this simulates that. We don't want to
// use safeGet as it throwing would mean we cannot use modals whilst the user isn't logged in.
// The longer term solution is to move our ModalManager into the React tree to inherit contexts properly.
this.matrixClient = MatrixClientPeg.get()!;
}
private onKeyDown = (e: KeyboardEvent | React.KeyboardEvent): void => {

6
src/components/views/dialogs/ScrollableBaseModal.tsx
View file

@ -43,7 +43,11 @@ export default abstract class ScrollableBaseModal<
}
protected get matrixClient(): MatrixClient {
return MatrixClientPeg.get();
// XXX: The contract on MatrixClientContext says it is only available within a LoggedInView subtree,
// given that modals function outside the MatrixChat React tree this simulates that. We don't want to
// use safeGet as it throwing would mean we cannot use modals whilst the user isn't logged in.
// The longer term solution is to move our ModalManager into the React tree to inherit contexts properly.
return MatrixClientPeg.get()!;
}
private onKeyDown = (e: KeyboardEvent | React.KeyboardEvent): void => {

3
tsconfig.json
View file

@ -7,7 +7,7 @@
"module": "commonjs",
"moduleResolution": "node",
"target": "es2016",
"noImplicitAny": false,
"noImplicitAny": true,
"noUnusedLocals": true,
"sourceMap": false,
"outDir": "./lib",
@ -16,6 +16,7 @@
"lib": ["es2020", "dom", "dom.iterable"],
"alwaysStrict": true,
"strictBindCallApply": true,
"strictNullChecks": true,
"noImplicitThis": true
},
"include": [