Add a basic PR checklist for all PRs (#9046)
* Add a basic PR checklist for all PRs It'll be mildly annoying for core developers who have to constantly remove or edit this, but it'll also serve as a good reminder to do these things. Note that signoff is not required for core developers. * *ahem*
This commit is contained in:
parent
17699dfcd0
commit
3abf8a1d51
1 changed files with 14 additions and 8 deletions
22
.github/PULL_REQUEST_TEMPLATE.md
vendored
22
.github/PULL_REQUEST_TEMPLATE.md
vendored
|
@ -1,15 +1,21 @@
|
|||
<!-- Please read https://github.com/matrix-org/matrix-js-sdk/blob/develop/CONTRIBUTING.md before submitting your pull request -->
|
||||
<!-- Thanks for submitting a PR! Please ensure the following requirements are met in order for us to review your PR -->
|
||||
|
||||
<!-- Include a Sign-Off as described in https://github.com/matrix-org/matrix-js-sdk/blob/develop/CONTRIBUTING.md#sign-off -->
|
||||
## Checklist
|
||||
|
||||
<!-- To specify text for the changelog entry (otherwise the PR title will be used):
|
||||
Notes:
|
||||
* [ ] Tests written for new code (and old code if feasible)
|
||||
* [ ] Linter and other CI checks pass
|
||||
* [ ] Sign-off given on the changes (see [CONTRIBUTING.md](https://github.com/matrix-org/matrix-react-sdk/blob/develop/CONTRIBUTING.md))
|
||||
|
||||
Changes in this project generate changelog entries in element-web by default.
|
||||
To suppress this:
|
||||
<!--
|
||||
If you would like to specify text for the changelog entry other than your PR title, add the following:
|
||||
|
||||
Notes: Add super cool feature
|
||||
|
||||
Changes in this project also generate changelogs in Element Web. To disable this, use the following:
|
||||
|
||||
element-web notes: none
|
||||
|
||||
...or to specify different notes:
|
||||
element-web notes: <notes>
|
||||
or specify alternative text:
|
||||
|
||||
element-web notes: Add super cool feature
|
||||
-->
|
||||
|
|
Loading…
Reference in a new issue