PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Use the right function for creating binary verification QR codes

Browse source 
`writeInt8` happened to work because the strings we're writing happen to fit within a single byte so the LSB doesn't matter. We actually want a 16 bit (2 byte) number in big-endian format.
This commit is contained in:
Travis Ralston 2020-02-26 13:37:19 -07:00
parent fe0bab7c81
commit 3abd3137c7
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/components/views/elements/crypto/VerificationQRCode.js
View file

@ -127,7 +127,7 @@ export default class VerificationQRCode extends React.PureComponent {
}; };
const appendInt = (i: number) => { const appendInt = (i: number) => {
const tmpBuf = Buffer.alloc(2); const tmpBuf = Buffer.alloc(2);
tmpBuf.writeInt8(i, 0); tmpBuf.writeInt16BE(i, 0);
buf = Buffer.concat([buf, tmpBuf]); buf = Buffer.concat([buf, tmpBuf]);
}; };
const appendStr = (s: string, enc: string, withLengthPrefix = true) => { const appendStr = (s: string, enc: string, withLengthPrefix = true) => {