PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Clarify merge options

Browse source
This commit is contained in:
J. Ryan Stinnett 2020-03-18 10:23:27 +00:00
parent bd8b3a9046
commit 3989f41985
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
docs/review.md
View file

@ -44,7 +44,8 @@ When reviewing code, here are some things we look for and also things we avoid:
review. Reviewers might be coming from different places and could miss other review. Reviewers might be coming from different places and could miss other
required PRs. required PRs.
* Avoid force pushing to a PR after first round of review * Avoid force pushing to a PR after first round of review
* Use merge commits when landing * Use the GitHub default of merge commits when landing (avoid alternate options
like squash or rebase)
* PR author merges after review (assuming they have write access) * PR author merges after review (assuming they have write access)
* Assign issues only when in progress to indicate to others what can be picked up * Assign issues only when in progress to indicate to others what can be picked up