PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Add notes on review request handling

Browse source
This commit is contained in:
J. Ryan Stinnett 2020-03-18 10:59:33 +00:00
parent 3989f41985
commit 34f3671c09
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
docs/review.md
View file

@ -40,6 +40,11 @@ When reviewing code, here are some things we look for and also things we avoid:
### Workflow ### Workflow
* Authors should request review from riot-web team by default (if someone on the
team is clearly the expert in an area, a direct review request to them may be
more appropriate)
* Reviewers should remove the team review request and request review from
themselves when starting a review to avoid double review
* Authors should link to other layers of their PR in their PR before requesting * Authors should link to other layers of their PR in their PR before requesting
review. Reviewers might be coming from different places and could miss other review. Reviewers might be coming from different places and could miss other
required PRs. required PRs.