PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Add additional metadata to feedback submitted through spotlight dialog (#9024)

Browse source
This commit is contained in:
Janne Mareike Koschinski 2022-07-11 12:00:40 +02:00 committed by GitHub
parent 8c67984f50
commit 32c008b3f0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/components/views/dialogs/FeedbackDialog.tsx
View file

@ -33,7 +33,9 @@ const existingIssuesUrl = "https://github.com/vector-im/element-web/issues" +
"?q=is%3Aopen+is%3Aissue+sort%3Areactions-%2B1-desc"; "?q=is%3Aopen+is%3Aissue+sort%3Areactions-%2B1-desc";
const newIssueUrl = "https://github.com/vector-im/element-web/issues/new/choose"; const newIssueUrl = "https://github.com/vector-im/element-web/issues/new/choose";
interface IProps extends IDialogProps {} interface IProps extends IDialogProps {
feature?: string;
}
const FeedbackDialog: React.FC<IProps> = (props: IProps) => { const FeedbackDialog: React.FC<IProps> = (props: IProps) => {
const feedbackRef = useRef<Field>(); const feedbackRef = useRef<Field>();
@ -55,7 +57,8 @@ const FeedbackDialog: React.FC<IProps> = (props: IProps) => {
const onFinished = (sendFeedback: boolean): void => { const onFinished = (sendFeedback: boolean): void => {
if (hasFeedback && sendFeedback) { if (hasFeedback && sendFeedback) {
if (rageshakeUrl) { if (rageshakeUrl) {
submitFeedback(rageshakeUrl, "feedback", comment, canContact); const label = props.feature ? `${props.feature}-feedback` : "feedback";
submitFeedback(rageshakeUrl, label, comment, canContact);
} }
Modal.createDialog(InfoDialog, { Modal.createDialog(InfoDialog, {

4
src/components/views/dialogs/spotlight/SpotlightDialog.tsx
View file

@ -1004,7 +1004,9 @@ const SpotlightDialog: React.FC<IProps> = ({ initialText = "", initialFilter = n
}; };
const openFeedback = SdkConfig.get().bug_report_endpoint_url ? () => { const openFeedback = SdkConfig.get().bug_report_endpoint_url ? () => {
Modal.createDialog(FeedbackDialog); Modal.createDialog(FeedbackDialog, {
feature: "spotlight",
});
} : null; } : null;
const activeDescendant = rovingContext.state.activeRef?.current?.id; const activeDescendant = rovingContext.state.activeRef?.current?.id;