PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Don't leave isRoomPublished as undefined

Browse source 
As this causes react to consider the component uncontrolled and then
warn when we change it to controlled
This commit is contained in:
David Baker 2016-08-03 18:23:38 +01:00
parent cbfb0ad998
commit 2d936a2850
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/components/views/rooms/RoomSettings.js
View file

@ -70,7 +70,9 @@ module.exports = React.createClass({
// is also called from the saving code so we must return the correct value here // is also called from the saving code so we must return the correct value here
// if we have it (although this could race if the user saves before we load whether // if we have it (although this could race if the user saves before we load whether
// the room is published or not). // the room is published or not).
isRoomPublished: this._originalIsRoomPublished, // Default to false if it's undefined, otherwise react complains about changing
// components from uncontrolled to controlled
isRoomPublished: this._originalIsRoomPublished || false,
}; };
}, },