PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Attempt to follow closely what RoomView did pre-ILAG

Browse source 
In terms of peeking and what happens to the state when joining. This is another attempt to mitigate https://github.com/vector-im/riot-web/issues/4307
This commit is contained in:
Luke Barnard 2017-06-14 16:48:34 +01:00
parent 302233db90
commit 2d6ba056d1
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/components/structures/RoomView.js
View file

@ -170,6 +170,12 @@ module.exports = React.createClass({
isInitialEventHighlighted: RoomViewStore.isInitialEventHighlighted(), isInitialEventHighlighted: RoomViewStore.isInitialEventHighlighted(),
}; };
// NB: This does assume that the roomID will not change for the lifetime of
// the RoomView instance
if (initial) {
newState.room = MatrixClientPeg.get().getRoom(newState.roomId);
}
// Clear the search results when clicking a search result (which changes the // Clear the search results when clicking a search result (which changes the
// currently scrolled to event, this.state.initialEventId). // currently scrolled to event, this.state.initialEventId).
if (this.state.initialEventId !== newState.initialEventId) { if (this.state.initialEventId !== newState.initialEventId) {
@ -186,7 +192,6 @@ module.exports = React.createClass({
// At this point, this.state.roomId could be null (e.g. the alias might not // At this point, this.state.roomId could be null (e.g. the alias might not
// have been resolved yet) so anything called here must handle this case. // have been resolved yet) so anything called here must handle this case.
this._onHaveRoom(); this._onHaveRoom();
this.onRoom(MatrixClientPeg.get().getRoom(this.state.roomId));
}); });
}, },
@ -205,7 +210,7 @@ module.exports = React.createClass({
// NB. We peek if we are not in the room, although if we try to peek into // NB. We peek if we are not in the room, although if we try to peek into
// a room in which we have a member event (ie. we've left) synapse will just // a room in which we have a member event (ie. we've left) synapse will just
// send us the same data as we get in the sync (ie. the last events we saw). // send us the same data as we get in the sync (ie. the last events we saw).
const room = MatrixClientPeg.get().getRoom(this.state.roomId); const room = this.state.room;
let isUserJoined = null; let isUserJoined = null;
if (room) { if (room) {
isUserJoined = room.hasMembershipState( isUserJoined = room.hasMembershipState(
@ -220,7 +225,6 @@ module.exports = React.createClass({
this.onJoinButtonClicked(); this.onJoinButtonClicked();
} else if (this.state.roomId) { } else if (this.state.roomId) {
console.log("Attempting to peek into room %s", this.state.roomId); console.log("Attempting to peek into room %s", this.state.roomId);
this.setState({ this.setState({
peekLoading: true, peekLoading: true,
}); });
@ -602,7 +606,7 @@ module.exports = React.createClass({
}, },
onRoom: function(room) { onRoom: function(room) {
if (!room || room.roomId !== this.state.roomId) { if (!room || room.roomId !== this.state.roomId || !this.state.joining) {
return; return;
} }
this.setState({ this.setState({