PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Tag Watcher don't create new filter if not needed, confuses references

Browse source 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
This commit is contained in:
Michael Telatynski 2020-07-20 14:36:12 +01:00
parent 7996013cd5
commit 29defa3e57
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/stores/room-list/TagWatcher.ts
View file

@ -54,7 +54,11 @@ export class TagWatcher {
continue; continue;
} }
newFilters.set(tag, new CommunityFilterCondition(group)); let filter = this.filters.get(tag);
if (!filter) {
filter = new CommunityFilterCondition(group);
}
newFilters.set(tag, filter);
} }
// Update the room list store's filters // Update the room list store's filters
@ -73,10 +77,6 @@ export class TagWatcher {
if (!filter) continue; if (!filter) continue;
this.store.removeFilter(filter); this.store.removeFilter(filter);
}
// Destroy any and all old filter conditions to prevent resource leaks
for (const filter of this.filters.values()) {
filter.destroy(); filter.destroy();
} }