PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Merge pull request #4130 from matrix-org/travis/fix-tab-complete

Browse source 
Don't print errors when the tab is used with no autocomplete present
This commit is contained in:
Travis Ralston 2020-02-25 13:21:39 -07:00 committed by GitHub
commit 28c5641180
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/components/views/rooms/BasicMessageComposer.js
View file

@ -471,10 +471,14 @@ export default class BasicMessageEditor extends React.Component {
const addedLen = range.replace([partCreator.pillCandidate(range.text)]); const addedLen = range.replace([partCreator.pillCandidate(range.text)]);
return model.positionForOffset(caret.offset + addedLen, true); return model.positionForOffset(caret.offset + addedLen, true);
}); });
await model.autoComplete.onTab();
if (!model.autoComplete.hasSelection()) { // Don't try to do things with the autocomplete if there is none shown
this.setState({showVisualBell: true}); if (model.autoComplete) {
model.autoComplete.close(); await model.autoComplete.onTab();
if (!model.autoComplete.hasSelection()) {
this.setState({showVisualBell: true});
model.autoComplete.close();
}
} }
} catch (err) { } catch (err) {
console.error(err); console.error(err);