Fix image upload preview size (#12607)

* Fix image upload preview size

and add a playwright test for it

* Add the actual playwright test
This commit is contained in:
David Baker 2024-06-12 23:35:02 +01:00 committed by GitHub
parent 6198ce511f
commit 25e4515c3c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 46 additions and 1 deletions

View file

@ -0,0 +1,45 @@
/*
Copyright 2024 The Matrix.org Foundation C.I.C.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
import { test, expect } from "../../element-web-test";
test.describe("Image Upload", () => {
test.use({
displayName: "Alice",
});
test.beforeEach(async ({ page, app, user }) => {
await app.client.createRoom({ name: "My Pictures" });
await app.viewRoomByName("My Pictures");
// Wait until configuration is finished
await expect(
page
.locator(".mx_GenericEventListSummary[data-layout='group'] .mx_GenericEventListSummary_summary")
.getByText(`${user.displayName} created and configured the room.`),
).toBeVisible();
});
test("should show image preview when uploading an image", async ({ page, app }) => {
await page
.locator(".mx_MessageComposer_actions input[type='file']")
.setInputFiles("playwright/sample-files/riot.png");
expect(page.getByRole("button", { name: "Upload" })).toBeEnabled();
expect(page.getByRole("button", { name: "Close dialog" })).toBeEnabled();
expect(page).toMatchScreenshot("image-upload-preview.png");
});
});

Binary file not shown.

After

Width:  |  Height:  |  Size: 67 KiB

View file

@ -333,7 +333,7 @@ legend {
z-index: var(--dialog-zIndex-standard); z-index: var(--dialog-zIndex-standard);
position: relative; position: relative;
width: 100%; width: 100%;
max-width: min-content; max-width: fit-content;
box-sizing: border-box; box-sizing: border-box;
max-height: calc(100% - var(--cpd-space-6x)); max-height: calc(100% - var(--cpd-space-6x));
display: flex; display: flex;