PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Merge pull request #3707 from matrix-org/t3chguy/improve_a11y_reactions_row_button

Browse source 
Switch ReactionsRowButton to an AccessibleButton for space/enter handling
This commit is contained in:
Michael Telatynski 2019-12-09 13:43:06 +00:00 committed by GitHub
commit 21647cf596
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/components/views/messages/ReactionsRowButton.js
View file

@ -126,10 +126,9 @@ export default class ReactionsRowButton extends React.PureComponent {
); );
} }
return <span className={classes} const AccessibleButton = sdk.getComponent('elements.AccessibleButton');
role="button" return <AccessibleButton className={classes}
aria-label={label} aria-label={label}
tabindex="0"
onClick={this.onClick} onClick={this.onClick}
onMouseOver={this.onMouseOver} onMouseOver={this.onMouseOver}
onMouseOut={this.onMouseOut} onMouseOut={this.onMouseOut}
@ -141,6 +140,6 @@ export default class ReactionsRowButton extends React.PureComponent {
{count} {count}
</span> </span>
{tooltip} {tooltip}
</span>; </AccessibleButton>;
} }
} }