Add a basic PR checklist for all PRs (#22811)
It'll be mildly annoying for core developers who have to constantly remove or edit this, but it'll also serve as a good reminder to do these things. Note that signoff is not required for core developers.
This commit is contained in:
parent
7708d0584b
commit
2047c09d61
1 changed files with 13 additions and 6 deletions
19
.github/PULL_REQUEST_TEMPLATE.md
vendored
19
.github/PULL_REQUEST_TEMPLATE.md
vendored
|
@ -1,11 +1,18 @@
|
||||||
<!-- Please read https://github.com/matrix-org/matrix-js-sdk/blob/develop/CONTRIBUTING.md before submitting your pull request -->
|
<!-- Thanks for submitting a PR! Please ensure the following requirements are met in order for us to review your PR -->
|
||||||
|
|
||||||
<!-- Include a Sign-Off as described in https://github.com/matrix-org/matrix-js-sdk/blob/develop/CONTRIBUTING.md#sign-off -->
|
## Checklist
|
||||||
|
|
||||||
<!-- To specify text for the changelog entry (otherwise the PR title will be used):
|
* [ ] Tests written for new code (and old code if feasible)
|
||||||
Notes:
|
* [ ] Linter and other CI checks pass
|
||||||
|
* [ ] Sign-off given on the changes (see [CONTRIBUTING.md](https://github.com/vector-im/element-web/blob/develop/CONTRIBUTING.md))
|
||||||
|
|
||||||
|
<!--
|
||||||
|
If you would like to specify text for the changelog entry other than your PR title, add the following:
|
||||||
|
|
||||||
|
Notes: Add super cool feature
|
||||||
|
|
||||||
|
For PRs which *only* affect the desktop version, please use:
|
||||||
|
|
||||||
Changelog entries will also appear in element-desktop. For PRs that *only* affect the desktop version:
|
|
||||||
Notes: none
|
Notes: none
|
||||||
element-desktop notes: <notes>
|
element-desktop notes: Add super cool feature
|
||||||
-->
|
-->
|
||||||
|
|
Loading…
Reference in a new issue