PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Deflake unskippable verification (#28222)

Browse source 
Discovering what is the correct way of asserting that an element is *not*
on screen with Playwright, which apparently is nontrivial.
This commit is contained in:
David Baker 2024-10-17 15:44:53 +01:00 committed by GitHub
parent 0c19991e3c
commit 1fc0122523
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
playwright/e2e/login/login.spec.ts
View file

@ -217,7 +217,7 @@ test.describe("Login", () => {
const h1 = await page.getByRole("heading", { name: "Verify this device", level: 1 }); const h1 = await page.getByRole("heading", { name: "Verify this device", level: 1 });
await expect(h1).toBeVisible(); await expect(h1).toBeVisible();
expect(h1.locator(".mx_CompleteSecurity_skip")).not.toBeVisible(); await expect(h1.locator(".mx_CompleteSecurity_skip")).toHaveCount(0);
}); });
}); });
}); });