PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Revert "Merge pull request #841 from matrix-org/luke/fix-double-dialogs"

Browse source 
This reverts commit 1913a32fbd, reversing
changes made to 0c16298c45.
This commit is contained in:
David Baker 2017-05-16 14:50:19 +01:00
parent 387529d130
commit 19dcd83aeb
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/components/views/dialogs/BaseDialog.js
View file

@ -57,9 +57,7 @@ export default React.createClass({
} }
}, },
// Must be when the key is released (and not pressed) otherwise componentWillUnmount _onKeyDown: function(e) {
// will focus another element which will receive future key events
_onKeyUp: function(e) {
if (e.keyCode === KeyCode.ESCAPE) { if (e.keyCode === KeyCode.ESCAPE) {
e.stopPropagation(); e.stopPropagation();
e.preventDefault(); e.preventDefault();
@ -81,7 +79,7 @@ export default React.createClass({
const TintableSvg = sdk.getComponent("elements.TintableSvg"); const TintableSvg = sdk.getComponent("elements.TintableSvg");
return ( return (
<div onKeyUp={this._onKeyUp} className={this.props.className}> <div onKeyDown={this._onKeyDown} className={this.props.className}>
<AccessibleButton onClick={this._onCancelClick} <AccessibleButton onClick={this._onCancelClick}
className="mx_Dialog_cancelButton" className="mx_Dialog_cancelButton"
> >