PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Fix spaces filtering sometimes lagging behind or behaving oddly

Browse source
This commit is contained in:
Michael Telatynski 2021-04-21 08:52:56 +01:00
parent ace8d59a2a
commit 1507f64f2b
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/stores/room-list/filters/SpaceFilterCondition.ts
View file

@ -42,10 +42,16 @@ export class SpaceFilterCondition extends EventEmitter implements IFilterConditi
private onStoreUpdate = async (): Promise<void> => { private onStoreUpdate = async (): Promise<void> => {
const beforeRoomIds = this.roomIds; const beforeRoomIds = this.roomIds;
this.roomIds = SpaceStore.instance.getSpaceFilteredRoomIds(this.space); // clone the set as it may be mutated by the space store internally
this.roomIds = new Set(SpaceStore.instance.getSpaceFilteredRoomIds(this.space));
if (setHasDiff(beforeRoomIds, this.roomIds)) { if (setHasDiff(beforeRoomIds, this.roomIds)) {
this.emit(FILTER_CHANGED); this.emit(FILTER_CHANGED);
// XXX: Room List Store has a bug where updates to the pre-filter during a local echo of a
// tags transition seem to be ignored, so refire in the next tick to work around it
setImmediate(() => {
this.emit(FILTER_CHANGED);
});
} }
}; };