PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Merge pull request #4073 from matrix-org/t3chguy/a11y_share_msg

Browse source 
Fix share message context menu option keyboard a11y
This commit is contained in:
Michael Telatynski 2020-02-19 17:41:28 +00:00 committed by GitHub
commit 12eb408c58
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 19 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/components/views/context_menus/MessageContextMenu.js
View file

@ -414,11 +414,16 @@ export default createReactClass({
}
// XXX: if we use room ID, we should also include a server where the event can be found (other than in the domain of the event ID)
const permalinkButton = (
<MenuItem className="mx_MessageContextMenu_field">
<a href={permalink} target="_blank" rel="noopener" onClick={this.onPermalinkClick} tabIndex={-1}>
<MenuItem
element="a"
className="mx_MessageContextMenu_field"
onClick={this.onPermalinkClick}
href={permalink}
target="_blank"
rel="noopener"
>
{ mxEvent.isRedacted() || mxEvent.getType() !== 'm.room.message'
? _t('Share Permalink') : _t('Share Message') }
</a>
</MenuItem>
);
@ -436,16 +441,15 @@ export default createReactClass({
isUrlPermitted(mxEvent.event.content.external_url)
) {
externalURLButton = (
<MenuItem className="mx_MessageContextMenu_field">
<a
href={mxEvent.event.content.external_url}
<MenuItem
element="a"
className="mx_MessageContextMenu_field"
target="_blank"
rel="noopener"
onClick={this.closeMenu}
tabIndex={-1}
href={mxEvent.event.content.external_url}
>
{ _t('Source URL') }
</a>
</MenuItem>
);
}