PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Default properties to {} to avoid passing it superfluously for events with no properties

Browse source
This commit is contained in:
James Salter 2021-07-28 17:54:35 +01:00
parent d401789f9e
commit 07eaee25d2
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/PosthogAnalytics.ts
View file

@ -302,7 +302,7 @@ export class PosthogAnalytics {
public async trackPseudonymousEvent<E extends IPseudonymousEvent>( public async trackPseudonymousEvent<E extends IPseudonymousEvent>(
eventName: E["eventName"], eventName: E["eventName"],
properties: E["properties"], properties: E["properties"] = {},
) { ) {
if (this.anonymity == Anonymity.Anonymous || this.anonymity == Anonymity.Disabled) return; if (this.anonymity == Anonymity.Anonymous || this.anonymity == Anonymity.Disabled) return;
await this.capture(eventName, properties); await this.capture(eventName, properties);
@ -310,7 +310,7 @@ export class PosthogAnalytics {
public async trackAnonymousEvent<E extends IAnonymousEvent>( public async trackAnonymousEvent<E extends IAnonymousEvent>(
eventName: E["eventName"], eventName: E["eventName"],
properties: E["properties"], properties: E["properties"] = {},
): Promise<void> { ): Promise<void> {
if (this.anonymity == Anonymity.Disabled) return; if (this.anonymity == Anonymity.Disabled) return;
await this.capture(eventName, properties); await this.capture(eventName, properties);

2
src/components/views/auth/Welcome.tsx
View file

@ -76,6 +76,6 @@ export default class Welcome extends React.PureComponent<IProps> {
} }
componentDidMount() { componentDidMount() {
getAnalytics().trackAnonymousEvent<IWelcomeScreenLoad>("welcome_screen_load", {}); getAnalytics().trackAnonymousEvent<IWelcomeScreenLoad>("welcome_screen_load");
} }
} }