PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

Merge pull request #1858 from matrix-org/luke/fix-piwik-crash3

Browse source 
Fix bug that caused crash when analytics HS/IS whitelists not specified
This commit is contained in:
Luke Barnard 2018-04-26 15:24:18 +01:00 committed by GitHub
commit 05f1ca6942
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/Analytics.js
View file

@ -190,6 +190,7 @@ class Analytics {
} }
_setVisitVariable(key, value) { _setVisitVariable(key, value) {
if (this.disabled) return;
this._paq.push(['setCustomVariable', customVariables[key].id, key, value, 'visit']); this._paq.push(['setCustomVariable', customVariables[key].id, key, value, 'visit']);
} }
@ -199,8 +200,8 @@ class Analytics {
const config = SdkConfig.get(); const config = SdkConfig.get();
if (!config.piwik) return; if (!config.piwik) return;
const whitelistedHSUrls = config.piwik.whitelistedHSUrls; const whitelistedHSUrls = config.piwik.whitelistedHSUrls || [];
const whitelistedISUrls = config.piwik.whitelistedISUrls; const whitelistedISUrls = config.piwik.whitelistedISUrls || [];
this._setVisitVariable('User Type', isGuest ? 'Guest' : 'Logged In'); this._setVisitVariable('User Type', isGuest ? 'Guest' : 'Logged In');
this._setVisitVariable('Homeserver URL', whitelistRedact(whitelistedHSUrls, homeserverUrl)); this._setVisitVariable('Homeserver URL', whitelistRedact(whitelistedHSUrls, homeserverUrl));

2
src/components/structures/MatrixChat.js
View file

@ -352,7 +352,7 @@ export default React.createClass({
defaultDeviceDisplayName: this.props.defaultDeviceDisplayName, defaultDeviceDisplayName: this.props.defaultDeviceDisplayName,
}); });
}).catch((e) => { }).catch((e) => {
console.error(`Error attempting to load session: ${e}`); console.error('Error attempting to load session', e);
return false; return false;
}).then((loadedSession) => { }).then((loadedSession) => {
if (!loadedSession) { if (!loadedSession) {