PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3

clean up objectHasDiff and short circuit it quicker

Browse source
This commit is contained in:
Michael Telatynski 2021-02-19 11:40:34 +00:00
parent 49f511bbab
commit 02ae1e954b
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/utils/objects.ts
View file

@ -89,10 +89,9 @@ export function objectHasDiff<O extends {}>(a: O, b: O): boolean {
if (a === b) return false; if (a === b) return false;
const aKeys = Object.keys(a); const aKeys = Object.keys(a);
const bKeys = Object.keys(b); const bKeys = Object.keys(b);
const possibleChanges = arrayUnion(aKeys, bKeys); if (aKeys.length !== bKeys.length) return true;
// if the amalgamation of both sets of keys has the a different length to the inputs then there must be a change
if (possibleChanges.length !== aKeys.length) return true;
const possibleChanges = arrayUnion(aKeys, bKeys);
return possibleChanges.some(k => a[k] !== b[k]); return possibleChanges.some(k => a[k] !== b[k]);
} }