PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3
element-web/.eslintrc.js

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

288 lines
13 KiB
JavaScript
Raw Normal View History

Use eslint config from the js sdk Extend the js sdk's eslint config to give as consistent a code style as possible. Add react/jsx/flow stuff that we use here.
2017-01-20 14:08:14 +00:00
module.exports = {
Switch to newer Babel specific config
2021-06-29 12:18:58 +00:00
plugins: ["matrix-org"],
Migrate to `eslint-plugin-matrix-org` This migrates to the new plugin form of our custom ESLint configs. As part of this, some packages are de-duplicated, configs streamlined, etc.
2021-04-01 12:17:09 +00:00
extends: ["plugin:matrix-org/babel", "plugin:matrix-org/react", "plugin:matrix-org/a11y"],
Add @typescript-eslint/no-base-to-string (#10091)
2023-02-07 10:08:10 +00:00
parserOptions: {
project: ["./tsconfig.json"],
},
Use eslint config from the js sdk Extend the js sdk's eslint config to give as consistent a code style as possible. Add react/jsx/flow stuff that we use here.
2017-01-20 14:08:14 +00:00
env: {
Use new eslint package- fix lint issues in ts and js
2020-06-23 15:41:36 +00:00
browser: true,
node: true,
Use eslint config from the js sdk Extend the js sdk's eslint config to give as consistent a code style as possible. Add react/jsx/flow stuff that we use here.
2017-01-20 14:08:14 +00:00
},
Use new eslint package- fix lint issues in ts and js
2020-06-23 15:41:36 +00:00
globals: {
LANGUAGES_FILE: "readonly",
Use eslint config from the js sdk Extend the js sdk's eslint config to give as consistent a code style as possible. Add react/jsx/flow stuff that we use here.
2017-01-20 14:08:14 +00:00
},
rules: {
Use new eslint package- fix lint issues in ts and js
2020-06-23 15:41:36 +00:00
// Things we do that break the ideal style
"no-constant-condition": "off",
"prefer-promise-reject-errors": "off",
"no-async-promise-executor": "off",
Migrate to `eslint-plugin-matrix-org` This migrates to the new plugin form of our custom ESLint configs. As part of this, some packages are de-duplicated, configs streamlined, etc.
2021-04-01 12:17:09 +00:00
"no-extra-boolean-cast": "off",
Use eslint config from the js sdk Extend the js sdk's eslint config to give as consistent a code style as possible. Add react/jsx/flow stuff that we use here.
2017-01-20 14:08:14 +00:00
Migrate to `eslint-plugin-matrix-org` This migrates to the new plugin form of our custom ESLint configs. As part of this, some packages are de-duplicated, configs streamlined, etc.
2021-04-01 12:17:09 +00:00
// Bind or arrow functions in props causes performance issues (but we
// currently use them in some places).
// It's disabled here, but we should using it sparingly.
"react/jsx-no-bind": "off",
"react/jsx-key": ["error"],
Apply restricted property rules to all files
2021-06-30 13:27:03 +00:00
"no-restricted-properties": [
"error",
...buildRestrictedPropertiesOptions(
["window.innerHeight", "window.innerWidth", "window.visualViewport"],
"Use UIStore to access window dimensions instead.",
),
...buildRestrictedPropertiesOptions(
["*.mxcUrlToHttp", "*.getHttpUriForMxc"],
"Use Media helper instead to centralise access for customisation.",
),
Replace setImmediate with setTimeout (#12614)
2024-06-13 14:15:59 +00:00
...buildRestrictedPropertiesOptions(["window.setImmediate"], "Use setTimeout instead."),
],
"no-restricted-globals": [
"error",
{
name: "setImmediate",
message: "Use setTimeout instead.",
},
Apply restricted property rules to all files
2021-06-30 13:27:03 +00:00
],
Add jsx-a11y eslint plugin (#7434) * add matrix-org a11y eslint plgin Signed-off-by: Kerry Archibald <kerrya@element.io> * add eslint a11y, enable and fix anchor-has-content rule Signed-off-by: Kerry Archibald <kerrya@element.io> * enable and fix jsx-a11y/no-redundant-roles Signed-off-by: Kerry Archibald <kerrya@element.io> * remove debug Signed-off-by: Kerry Archibald <kerrya@element.io> * i18n Signed-off-by: Kerry Archibald <kerrya@element.io> * use jsx-a11y via matrix-org-eslint Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-01-03 17:51:58 +00:00
Switch to importing models/Room from main js-sdk export (#11361) * Switch to importing TypedEventEmitter from main js-sdk export * Switch to importing js-sdk/matrix in cypress * Remove duplicated imports * Fix lint:js-fix to run prettier last otherwise ESLint --fix may cause a mess * Add lint rule * Switch to importing models/Room from main js-sdk export * Fix cypress-axe import * Fix more imports * Fix cypress-axe import * Fix duplicated lint rule
2023-08-04 07:36:16 +00:00
"import/no-duplicates": ["error"],
Mandate use of js-sdk/src/matrix import over js-sdk/src (#7933)
2022-03-01 20:42:05 +00:00
// Ban matrix-js-sdk/src imports in favour of matrix-js-sdk/src/matrix imports to prevent unleashing hell.
"no-restricted-imports": [
"error",
{
paths: [
{
name: "matrix-js-sdk",
message: "Please use matrix-js-sdk/src/matrix instead",
},
{
name: "matrix-js-sdk/",
message: "Please use matrix-js-sdk/src/matrix instead",
},
{
name: "matrix-js-sdk/src",
message: "Please use matrix-js-sdk/src/matrix instead",
},
{
name: "matrix-js-sdk/src/",
message: "Please use matrix-js-sdk/src/matrix instead",
},
{
name: "matrix-js-sdk/src/index",
message: "Please use matrix-js-sdk/src/matrix instead",
},
{
name: "matrix-react-sdk",
message: "Please use matrix-react-sdk/src/index instead",
},
{
name: "matrix-react-sdk/",
message: "Please use matrix-react-sdk/src/index instead",
},
Don't consider textual characters to be emoji (#12582) * Don't consider textual characters to be emoji We were using emojibase-regex to match emoji within messages. However, the docs (https://emojibase.dev/docs/regex/) state that this regex matches both emoji and text presentation characters. This is not what we want, and will result in false positives for characters like '↔' that could turn into an emoji if paired with a variation selector. Unfortunately, none of the other regexes provided by Emojibase do what we want either (https://github.com/milesj/emojibase/issues/174). In the meantime, browser support for the RGI_Emoji character sequence class has made it feasible to write an emoji regex by hand, so that's what I've done. * Add a fallback for BIGEMOJI_REGEX as well
2024-07-04 17:48:07 +00:00
{
name: "emojibase-regex",
message:
"This regex doesn't actually test for emoji. See the docs at https://emojibase.dev/docs/regex/ and prefer our own EMOJI_REGEX from HtmlUtils.",
},
Mandate use of js-sdk/src/matrix import over js-sdk/src (#7933)
2022-03-01 20:42:05 +00:00
],
patterns: [
{
Switch to importing most things from the main matrix-js-sdk export (#11406) * Switch to importing most things from the main matrix-js-sdk export * fix imports * Iterate * Fix tests
2023-08-15 15:00:17 +00:00
group: [
"matrix-js-sdk/src/**",
"!matrix-js-sdk/src/matrix",
Clean up some references to internal js-sdk classes (#12363) * Fix references to `crypto-api/verification` This is supposed to be an internal module; use the front door instead. * `IRecoveryKey` -> `GeneratedSecretStorageKey` `IRecoveryKey` is just a backwards-compatibility alias for `GeneratedSecretStorageKey` * `ISecretStorageKeyInfo` -> `SecretStorage.SecretStorageKeyDescription` Again, same thing * `IPassphraseInfo` -> `SecretStorage.PassphraseInfo` * Remove unused import restriction exceptions
2024-03-22 12:28:13 +00:00
"!matrix-js-sdk/src/crypto-api",
Reuse media content/info types from the js-sdk (#12308)
2024-03-11 09:30:00 +00:00
"!matrix-js-sdk/src/types",
Use test helpers from js-sdk for encrypted events (#12364) * Use test helpers from js-sdk for encrypted events Rather than gut-wrenching into the matrix-js-sdk, let's use the newly-exported test helpers to generate encrypted events. * Fix up
2024-03-22 15:48:29 +00:00
"!matrix-js-sdk/src/testing",
Switch to importing most things from the main matrix-js-sdk export (#11406) * Switch to importing most things from the main matrix-js-sdk export * fix imports * Iterate * Fix tests
2023-08-15 15:00:17 +00:00
"matrix-js-sdk/lib",
"matrix-js-sdk/lib/",
"matrix-js-sdk/lib/**",
// XXX: Temporarily allow these as they are not available via the main export
"!matrix-js-sdk/src/logger",
"!matrix-js-sdk/src/errors",
"!matrix-js-sdk/src/utils",
"!matrix-js-sdk/src/version-support",
"!matrix-js-sdk/src/randomstring",
"!matrix-js-sdk/src/sliding-sync",
"!matrix-js-sdk/src/browser-index",
"!matrix-js-sdk/src/feature",
"!matrix-js-sdk/src/NamespacedValue",
"!matrix-js-sdk/src/ReEmitter",
"!matrix-js-sdk/src/event-mapper",
"!matrix-js-sdk/src/interactive-auth",
"!matrix-js-sdk/src/secret-storage",
"!matrix-js-sdk/src/room-hierarchy",
"!matrix-js-sdk/src/rendezvous",
"!matrix-js-sdk/src/indexeddb-worker",
"!matrix-js-sdk/src/pushprocessor",
"!matrix-js-sdk/src/extensible_events_v1",
"!matrix-js-sdk/src/extensible_events_v1/PollStartEvent",
"!matrix-js-sdk/src/extensible_events_v1/PollResponseEvent",
"!matrix-js-sdk/src/extensible_events_v1/PollEndEvent",
"!matrix-js-sdk/src/extensible_events_v1/InvalidEventError",
"!matrix-js-sdk/src/crypto",
"!matrix-js-sdk/src/crypto/aes",
"!matrix-js-sdk/src/crypto/keybackup",
"!matrix-js-sdk/src/crypto/deviceinfo",
"!matrix-js-sdk/src/crypto/recoverykey",
"!matrix-js-sdk/src/crypto/dehydration",
"!matrix-js-sdk/src/oidc",
"!matrix-js-sdk/src/oidc/discovery",
"!matrix-js-sdk/src/oidc/authorize",
"!matrix-js-sdk/src/oidc/validate",
"!matrix-js-sdk/src/oidc/error",
"!matrix-js-sdk/src/oidc/register",
"!matrix-js-sdk/src/webrtc",
"!matrix-js-sdk/src/webrtc/call",
"!matrix-js-sdk/src/webrtc/callFeed",
"!matrix-js-sdk/src/webrtc/mediaHandler",
"!matrix-js-sdk/src/webrtc/callEventTypes",
"!matrix-js-sdk/src/webrtc/callEventHandler",
"!matrix-js-sdk/src/webrtc/groupCallEventHandler",
"!matrix-js-sdk/src/models",
"!matrix-js-sdk/src/models/read-receipt",
"!matrix-js-sdk/src/models/relations-container",
"!matrix-js-sdk/src/models/related-relations",
Remove MatrixRTC realted import ES lint exceptions using a index.ts for matrixrtc (#12780) * update restricted import rules for matrixrtc * review * upgrade matrix-js-sdk * add missing import
2024-07-25 12:49:41 +00:00
"!matrix-js-sdk/src/matrixrtc",
Switch to importing most things from the main matrix-js-sdk export (#11406) * Switch to importing most things from the main matrix-js-sdk export * fix imports * Iterate * Fix tests
2023-08-15 15:00:17 +00:00
],
message: "Please use matrix-js-sdk/src/matrix instead",
Mandate use of js-sdk/src/matrix import over js-sdk/src (#7933)
2022-03-01 20:42:05 +00:00
},
Don't consider textual characters to be emoji (#12582) * Don't consider textual characters to be emoji We were using emojibase-regex to match emoji within messages. However, the docs (https://emojibase.dev/docs/regex/) state that this regex matches both emoji and text presentation characters. This is not what we want, and will result in false positives for characters like '↔' that could turn into an emoji if paired with a variation selector. Unfortunately, none of the other regexes provided by Emojibase do what we want either (https://github.com/milesj/emojibase/issues/174). In the meantime, browser support for the RGI_Emoji character sequence class has made it feasible to write an emoji regex by hand, so that's what I've done. * Add a fallback for BIGEMOJI_REGEX as well
2024-07-04 17:48:07 +00:00
{
group: ["emojibase-regex/emoji*"],
message:
"This regex doesn't actually test for emoji. See the docs at https://emojibase.dev/docs/regex/ and prefer our own EMOJI_REGEX from HtmlUtils.",
},
Mandate use of js-sdk/src/matrix import over js-sdk/src (#7933)
2022-03-01 20:42:05 +00:00
],
},
],
Add jsx-a11y eslint plugin (#7434) * add matrix-org a11y eslint plgin Signed-off-by: Kerry Archibald <kerrya@element.io> * add eslint a11y, enable and fix anchor-has-content rule Signed-off-by: Kerry Archibald <kerrya@element.io> * enable and fix jsx-a11y/no-redundant-roles Signed-off-by: Kerry Archibald <kerrya@element.io> * remove debug Signed-off-by: Kerry Archibald <kerrya@element.io> * i18n Signed-off-by: Kerry Archibald <kerrya@element.io> * use jsx-a11y via matrix-org-eslint Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-01-03 17:51:58 +00:00
// There are too many a11y violations to fix at once
// Turn violated rules off until they are fixed
"jsx-a11y/aria-activedescendant-has-tabindex": "off",
"jsx-a11y/click-events-have-key-events": "off",
"jsx-a11y/interactive-supports-focus": "off",
"jsx-a11y/media-has-caption": "off",
"jsx-a11y/mouse-events-have-key-events": "off",
"jsx-a11y/no-autofocus": "off",
"jsx-a11y/no-noninteractive-element-interactions": "off",
"jsx-a11y/no-noninteractive-element-to-interactive-role": "off",
"jsx-a11y/no-noninteractive-tabindex": "off",
"jsx-a11y/no-static-element-interactions": "off",
"jsx-a11y/role-supports-aria-props": "off",
Eslint - require copyright header rule (#8514) * bump eslint plugin to 0.5.2 Signed-off-by: Kerry Archibald <kerrya@element.io> * add rule Signed-off-by: Kerry Archibald <kerrya@element.io> * add missing copyright headers Signed-off-by: Kerry Archibald <kerrya@element.io> * fix comment order Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-05-06 09:09:28 +00:00
"matrix-org/require-copyright-header": "error",
Migrate to `eslint-plugin-matrix-org` This migrates to the new plugin form of our custom ESLint configs. As part of this, some packages are de-duplicated, configs streamlined, etc.
2021-04-01 12:17:09 +00:00
},
Revert "replace all require(.svg) with esm import" (#7969) * Revert "replace all require(svgs) with esm import (#7948)" This reverts commit 61cd463a3b57917d9206c98e6e75fc5b57033102. * add .default to svg icon inline requires Signed-off-by: Kerry Archibald <kerrya@element.io> * add shameful eslint ignore Signed-off-by: Kerry Archibald <kerrya@element.io> * format eslintrc Signed-off-by: Kerry Archibald <kerrya@element.io> * add missed MFileBody change Signed-off-by: Kerry Archibald <kerrya@element.io> * one more broken svg Signed-off-by: Kerry Archibald <kerrya@element.io> * and ignore it Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-03-03 17:51:38 +00:00
overrides: [
{
Remove Cypress & Playwright in their entirety (#12145)
2024-01-16 09:48:49 +00:00
files: ["src/**/*.{ts,tsx}", "test/**/*.{ts,tsx}", "playwright/**/*.ts"],
Revert "replace all require(.svg) with esm import" (#7969) * Revert "replace all require(svgs) with esm import (#7948)" This reverts commit 61cd463a3b57917d9206c98e6e75fc5b57033102. * add .default to svg icon inline requires Signed-off-by: Kerry Archibald <kerrya@element.io> * add shameful eslint ignore Signed-off-by: Kerry Archibald <kerrya@element.io> * format eslintrc Signed-off-by: Kerry Archibald <kerrya@element.io> * add missed MFileBody change Signed-off-by: Kerry Archibald <kerrya@element.io> * one more broken svg Signed-off-by: Kerry Archibald <kerrya@element.io> * and ignore it Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-03-03 17:51:38 +00:00
extends: ["plugin:matrix-org/typescript", "plugin:matrix-org/react"],
rules: {
Enable `@typescript-eslint/explicit-function-return-type` in /src (#9788) * Enable `@typescript-eslint/explicit-member-accessibility` on /src * Prettier * Enable `@typescript-eslint/explicit-function-return-type` in /src * Fix types * tsc strict fixes * Delint * Fix test * Fix bad merge
2023-01-12 13:25:14 +00:00
"@typescript-eslint/explicit-function-return-type": [
"error",
{
allowExpressions: true,
},
],
Update eslint-plugin-matrix-org to 0.8.0
2022-12-09 13:31:56 +00:00
Revert "replace all require(.svg) with esm import" (#7969) * Revert "replace all require(svgs) with esm import (#7948)" This reverts commit 61cd463a3b57917d9206c98e6e75fc5b57033102. * add .default to svg icon inline requires Signed-off-by: Kerry Archibald <kerrya@element.io> * add shameful eslint ignore Signed-off-by: Kerry Archibald <kerrya@element.io> * format eslintrc Signed-off-by: Kerry Archibald <kerrya@element.io> * add missed MFileBody change Signed-off-by: Kerry Archibald <kerrya@element.io> * one more broken svg Signed-off-by: Kerry Archibald <kerrya@element.io> * and ignore it Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-03-03 17:51:38 +00:00
// Things we do that break the ideal style
"prefer-promise-reject-errors": "off",
"no-extra-boolean-cast": "off",
Migrate to `eslint-plugin-matrix-org` This migrates to the new plugin form of our custom ESLint configs. As part of this, some packages are de-duplicated, configs streamlined, etc.
2021-04-01 12:17:09 +00:00
Revert "replace all require(.svg) with esm import" (#7969) * Revert "replace all require(svgs) with esm import (#7948)" This reverts commit 61cd463a3b57917d9206c98e6e75fc5b57033102. * add .default to svg icon inline requires Signed-off-by: Kerry Archibald <kerrya@element.io> * add shameful eslint ignore Signed-off-by: Kerry Archibald <kerrya@element.io> * format eslintrc Signed-off-by: Kerry Archibald <kerrya@element.io> * add missed MFileBody change Signed-off-by: Kerry Archibald <kerrya@element.io> * one more broken svg Signed-off-by: Kerry Archibald <kerrya@element.io> * and ignore it Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-03-03 17:51:38 +00:00
// Remove Babel things manually due to override limitations
"@babel/no-invalid-this": ["off"],
Rework lint comments
2021-06-29 12:35:43 +00:00
Revert "replace all require(.svg) with esm import" (#7969) * Revert "replace all require(svgs) with esm import (#7948)" This reverts commit 61cd463a3b57917d9206c98e6e75fc5b57033102. * add .default to svg icon inline requires Signed-off-by: Kerry Archibald <kerrya@element.io> * add shameful eslint ignore Signed-off-by: Kerry Archibald <kerrya@element.io> * format eslintrc Signed-off-by: Kerry Archibald <kerrya@element.io> * add missed MFileBody change Signed-off-by: Kerry Archibald <kerrya@element.io> * one more broken svg Signed-off-by: Kerry Archibald <kerrya@element.io> * and ignore it Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-03-03 17:51:38 +00:00
// We're okay being explicit at the moment
"@typescript-eslint/no-empty-interface": "off",
// We disable this while we're transitioning
"@typescript-eslint/no-explicit-any": "off",
// We'd rather not do this but we do
"@typescript-eslint/ban-ts-comment": "off",
Disable no-non-null assertions lint rule (#8699) This *allows* us to use `variable!.prop` to ensure `variable` is not null/undefined.
2022-05-30 06:21:55 +00:00
// We're okay with assertion errors when we ask for them
"@typescript-eslint/no-non-null-assertion": "off",
Revert "replace all require(.svg) with esm import" (#7969) * Revert "replace all require(svgs) with esm import (#7948)" This reverts commit 61cd463a3b57917d9206c98e6e75fc5b57033102. * add .default to svg icon inline requires Signed-off-by: Kerry Archibald <kerrya@element.io> * add shameful eslint ignore Signed-off-by: Kerry Archibald <kerrya@element.io> * format eslintrc Signed-off-by: Kerry Archibald <kerrya@element.io> * add missed MFileBody change Signed-off-by: Kerry Archibald <kerrya@element.io> * one more broken svg Signed-off-by: Kerry Archibald <kerrya@element.io> * and ignore it Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-03-03 17:51:38 +00:00
},
Remove redundant lint dependencies These are no longer needed with the new standard lint repo.
2020-07-29 11:00:42 +00:00
},
Revert "replace all require(.svg) with esm import" (#7969) * Revert "replace all require(svgs) with esm import (#7948)" This reverts commit 61cd463a3b57917d9206c98e6e75fc5b57033102. * add .default to svg icon inline requires Signed-off-by: Kerry Archibald <kerrya@element.io> * add shameful eslint ignore Signed-off-by: Kerry Archibald <kerrya@element.io> * format eslintrc Signed-off-by: Kerry Archibald <kerrya@element.io> * add missed MFileBody change Signed-off-by: Kerry Archibald <kerrya@element.io> * one more broken svg Signed-off-by: Kerry Archibald <kerrya@element.io> * and ignore it Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-03-03 17:51:38 +00:00
// temporary override for offending icon require files
{
files: [
"src/SdkConfig.ts",
"src/components/structures/FileDropTarget.tsx",
"src/components/structures/RoomStatusBar.tsx",
"src/components/structures/UserMenu.tsx",
"src/components/views/avatars/WidgetAvatar.tsx",
"src/components/views/dialogs/AddExistingToSpaceDialog.tsx",
"src/components/views/dialogs/ForwardDialog.tsx",
"src/components/views/dialogs/InviteDialog.tsx",
"src/components/views/dialogs/ModalWidgetDialog.tsx",
"src/components/views/dialogs/UploadConfirmDialog.tsx",
"src/components/views/dialogs/security/SetupEncryptionDialog.tsx",
"src/components/views/elements/AddressTile.tsx",
"src/components/views/elements/AppWarning.tsx",
"src/components/views/elements/SSOButtons.tsx",
"src/components/views/messages/MAudioBody.tsx",
"src/components/views/messages/MImageBody.tsx",
"src/components/views/messages/MFileBody.tsx",
"src/components/views/messages/MStickerBody.tsx",
"src/components/views/messages/MVideoBody.tsx",
"src/components/views/messages/MVoiceMessageBody.tsx",
"src/components/views/right_panel/EncryptionPanel.tsx",
"src/components/views/rooms/EntityTile.tsx",
"src/components/views/rooms/LinkPreviewGroup.tsx",
"src/components/views/rooms/MemberList.tsx",
"src/components/views/rooms/MessageComposer.tsx",
"src/components/views/rooms/ReplyPreview.tsx",
"src/components/views/settings/tabs/room/SecurityRoomSettingsTab.tsx",
"src/components/views/settings/tabs/user/GeneralUserSettingsTab.tsx",
],
rules: {
"@typescript-eslint/no-var-requires": "off",
},
},
Enable `@typescript-eslint/explicit-member-accessibility` on /src (#9785) * Enable `@typescript-eslint/explicit-member-accessibility` on /src * Prettier
2022-12-16 12:29:59 +00:00
{
Remove Cypress & Playwright in their entirety (#12145)
2024-01-16 09:48:49 +00:00
files: ["test/**/*.{ts,tsx}", "playwright/**/*.ts"],
Add ESLint Jest (#10261)
2023-03-01 15:23:35 +00:00
extends: ["plugin:matrix-org/jest"],
Enable `@typescript-eslint/explicit-member-accessibility` on /src (#9785) * Enable `@typescript-eslint/explicit-member-accessibility` on /src * Prettier
2022-12-16 12:29:59 +00:00
rules: {
// We don't need super strict typing in test utilities
"@typescript-eslint/explicit-function-return-type": "off",
"@typescript-eslint/explicit-member-accessibility": "off",
Add ESLint Jest (#10261)
2023-03-01 15:23:35 +00:00
Remove Cypress & Playwright in their entirety (#12145)
2024-01-16 09:48:49 +00:00
// Jest/Playwright specific
Add ESLint Jest (#10261)
2023-03-01 15:23:35 +00:00
// Disabled tests are a reality for now but as soon as all of the xits are
// eliminated, we should enforce this.
"jest/no-disabled-tests": "off",
// Also treat "oldBackendOnly" as a test function.
// Used in some crypto tests.
"jest/no-standalone-expect": [
"error",
{
additionalTestBlockFunctions: ["beforeAll", "beforeEach", "oldBackendOnly"],
},
],
Enable `@typescript-eslint/explicit-member-accessibility` on /src (#9785) * Enable `@typescript-eslint/explicit-member-accessibility` on /src * Prettier
2022-12-16 12:29:59 +00:00
},
},
Add Playwright end to end testing (#11912) * Install playwright Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Add foundations for writing tests under Playwright Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * .gitignore juggling Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Add tsconfig and fix eslint rules Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> --------- Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2023-11-21 17:33:32 +00:00
{
files: ["playwright/**/*.ts"],
parserOptions: {
project: ["./playwright/tsconfig.json"],
},
},
Revert "replace all require(.svg) with esm import" (#7969) * Revert "replace all require(svgs) with esm import (#7948)" This reverts commit 61cd463a3b57917d9206c98e6e75fc5b57033102. * add .default to svg icon inline requires Signed-off-by: Kerry Archibald <kerrya@element.io> * add shameful eslint ignore Signed-off-by: Kerry Archibald <kerrya@element.io> * format eslintrc Signed-off-by: Kerry Archibald <kerrya@element.io> * add missed MFileBody change Signed-off-by: Kerry Archibald <kerrya@element.io> * one more broken svg Signed-off-by: Kerry Archibald <kerrya@element.io> * and ignore it Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-03-03 17:51:38 +00:00
],
Add ESLint shared settings to detect React version
2021-08-25 08:36:35 +00:00
settings: {
react: {
version: "detect",
Add rule to group imports by external and internal Signed-off-by: Aaron Raimist <aaron@raim.ist>
2021-10-22 22:21:46 +00:00
},
},
Use eslint config from the js sdk Extend the js sdk's eslint config to give as consistent a code style as possible. Add react/jsx/flow stuff that we use here.
2017-01-20 14:08:14 +00:00
};
prevent reflow in app when accessing window dimensions
2021-05-25 09:25:36 +00:00
function buildRestrictedPropertiesOptions(properties, message) {
return properties.map((prop) => {
Lint MXC APIs to centralise access This adds linting rules to ensure that MXC APIs are only accessed via the `Media` helper so they can be customised easily when desired. Fixes https://github.com/vector-im/element-web/issues/16933
2021-06-30 13:19:39 +00:00
let [object, property] = prop.split(".");
if (object === "*") {
object = undefined;
}
prevent reflow in app when accessing window dimensions
2021-05-25 09:25:36 +00:00
return {
object,
property,
message,
};
});
}
Reference in a new issue Copy permalink