PrivateCoffee/alltube
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix(download): improve stream selection logic

Browse source 
Added a check to ensure remux stream is selected only when there are multiple video URLs and no 'entries' in the video object. This prevents unnecessary remuxing when entries exist, optimizing resource usage and maintaining proper stream handling.
This commit is contained in:
Kumi 2024-11-04 18:51:54 +01:00
parent 2328f25a20
commit 3d39af7a98
Signed by: kumi
GPG key ID: ECBCC9082395383F
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
classes/Controller/DownloadController.php
View file

@ -112,6 +112,8 @@ class DownloadController extends BaseController
$to = $request->getQueryParam('to'); $to = $request->getQueryParam('to');
} }
assert((is_string($from) || is_null($from)) && (is_string($to) || is_null($to)));
$response = $response->withHeader( $response = $response->withHeader(
'Content-Disposition', 'Content-Disposition',
'attachment; filename="' . 'attachment; filename="' .
@ -281,7 +283,7 @@ class DownloadController extends BaseController
*/ */
$videoUrls = []; $videoUrls = [];
} }
if (count($videoUrls) > 1) { if (count($videoUrls) > 1 && !isset($this->video->entries)) {
return $this->getRemuxStream($request, $response); return $this->getRemuxStream($request, $response);
} elseif ($this->config->stream && (isset($this->video->entries) || $request->getQueryParam('stream'))) { } elseif ($this->config->stream && (isset($this->video->entries) || $request->getQueryParam('stream'))) {
return $this->getStream($request, $response); return $this->getStream($request, $response);
@ -311,6 +313,9 @@ class DownloadController extends BaseController
*/ */
private function getConvertedResponse(Request $request, Response $response): Response private function getConvertedResponse(Request $request, Response $response): Response
{ {
assert(is_string($request->getQueryParam('customFormat')));
assert(is_int($request->getQueryParam('customBitrate')));
$response = $response->withHeader( $response = $response->withHeader(
'Content-Disposition', 'Content-Disposition',
'attachment; filename="' . 'attachment; filename="' .