From c3dff2394cbb18eefb821cf04c16e476b22a4ff5 Mon Sep 17 00:00:00 2001 From: Kumi Date: Tue, 2 Jul 2024 17:31:28 +0200 Subject: [PATCH] fix(url): simplify URL parameter extraction Refactored URL parameter extraction to use the URL API, enhancing readability and maintainability. Improved reliability by leveraging built-in methods, which are less error-prone than regex-based extraction. --- global.js | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/global.js b/global.js index 40c020f..8ee05de 100644 --- a/global.js +++ b/global.js @@ -14,12 +14,9 @@ document.addEventListener("DOMContentLoaded", function () { // Function to get URL parameters function getUrlParameter(name) { - name = name.replace(/[\[]/, "\\[").replace(/[\]]/, "\\]"); - var regex = new RegExp("[\\?&]" + name + "=([^&#]*)"); - var results = regex.exec(location.search); - return results === null - ? "" - : decodeURIComponent(results[1].replace(/\+/g, " ")); + url = document.location.href; + urlobj = new URL(url) + return urlobj.searchParams.get(name); } // Check if the 'embed' parameter is set to '1'