6adc757097
To mitigate this problem, the original message has been wrapped automatically by the mailing list software. This patch fixes a problem where the AR8035 PHY can't be detected on the Cisco Meraki MR24, when the ethernet cable is not connected during boot. Russell Senior reported: |This appears to be a problem during probing of the AR8035 |phy chip. When ethernet has no link, the phy detection fails, |and eth0 is not created. Plugging ethernet later has no effect, |because there is no interface as far as the kernel is |concerned. The relevant part of the boot log looks like this: | |[ 0.876611] /plb/opb/emac-rgmii@ef601500: input 0 in RGMII mode |[ 0.882532] /plb/opb/ethernet@ef600c00: reset timeout |[ 0.888546] /plb/opb/ethernet@ef600c00: can't find PHY! (<https://bugs.lede-project.org/index.php?do=details&task_id=687>) Fixes FS#687 Cc: Chris Blake <chrisrblake93@gmail.com> Reported-by: Russell Senior <russell@personaltelco.net> Fixes: 23fbb5a87c56e98 ("emac: Fix EMAC soft reset on 460EX/GT") Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
51 lines
1.8 KiB
Diff
51 lines
1.8 KiB
Diff
--- a/drivers/net/ethernet/ibm/emac/core.c
|
|
+++ b/drivers/net/ethernet/ibm/emac/core.c
|
|
@@ -129,6 +129,7 @@ static inline void emac_report_timeout_e
|
|
{
|
|
if (emac_has_feature(dev, EMAC_FTR_440GX_PHY_CLK_FIX |
|
|
EMAC_FTR_460EX_PHY_CLK_FIX |
|
|
+ EMAC_FTR_APM821XX_PHY_CLK_FIX |
|
|
EMAC_FTR_440EP_PHY_CLK_FIX))
|
|
DBG(dev, "%s" NL, error);
|
|
else if (net_ratelimit())
|
|
@@ -146,6 +147,10 @@ static inline void emac_rx_clk_tx(struct
|
|
if (emac_has_feature(dev, EMAC_FTR_440EP_PHY_CLK_FIX))
|
|
dcri_clrset(SDR0, SDR0_MFR,
|
|
0, SDR0_MFR_ECS >> dev->cell_index);
|
|
+
|
|
+ if (emac_has_feature(dev, EMAC_FTR_APM821XX_PHY_CLK_FIX))
|
|
+ dcri_clrset(SDR0, SDR0_ETH_CFG,
|
|
+ 0, 0x00000100 >> dev->cell_index);
|
|
#endif
|
|
}
|
|
|
|
@@ -155,6 +160,10 @@ static inline void emac_rx_clk_default(s
|
|
if (emac_has_feature(dev, EMAC_FTR_440EP_PHY_CLK_FIX))
|
|
dcri_clrset(SDR0, SDR0_MFR,
|
|
SDR0_MFR_ECS >> dev->cell_index, 0);
|
|
+
|
|
+ if (emac_has_feature(dev, EMAC_FTR_APM821XX_PHY_CLK_FIX))
|
|
+ dcri_clrset(SDR0, SDR0_ETH_CFG,
|
|
+ 0x00000100 >> dev->cell_index, 0);
|
|
#endif
|
|
}
|
|
|
|
@@ -2617,6 +2626,7 @@ static int emac_init_config(struct emac_
|
|
if (of_device_is_compatible(np, "ibm,emac-apm821xx")) {
|
|
dev->features |= (EMAC_APM821XX_REQ_JUMBO_FRAME_SIZE |
|
|
EMAC_FTR_APM821XX_NO_HALF_DUPLEX |
|
|
+ EMAC_FTR_APM821XX_PHY_CLK_FIX |
|
|
EMAC_FTR_460EX_PHY_CLK_FIX);
|
|
}
|
|
} else if (of_device_is_compatible(np, "ibm,emac4")) {
|
|
--- a/drivers/net/ethernet/ibm/emac/core.h
|
|
+++ b/drivers/net/ethernet/ibm/emac/core.h
|
|
@@ -333,6 +333,8 @@ struct emac_instance {
|
|
*/
|
|
#define EMAC_FTR_APM821XX_NO_HALF_DUPLEX 0x00001000
|
|
|
|
+#define EMAC_FTR_APM821XX_PHY_CLK_FIX 0x000002000
|
|
+
|
|
/* Right now, we don't quite handle the always/possible masks on the
|
|
* most optimal way as we don't have a way to say something like
|
|
* always EMAC4. Patches welcome.
|