Commit graph

16 commits

Author SHA1 Message Date
Felix Fietkau
679cab88fe Fix a memory leak in hotplug2 environment handling. Bump hotplug2 to the latest svn revision, remove obsolete patches.
Memory leak is caused by the way hotplug2 handles environment variables,
using setenv() and unsetenv(). setenv() creates copies of the supplied
strings, but, due to a POSIX blunder, these copies are never destroyed
by unsetenv(), neither in glibc nor uclibc - not until the program
terminates.

Since some events are handled directly in the main process, even when
configured with the "fork" worker, hotplug2 memory usage will keep
growing over time. This can be observed by running "udevtrigger" and
noting the increase in hotplug2 VmRSS after each run.

This patch uses putenv() instead, which leaves storage management to
the caller, so that we can explicitly delete stuff when it's no longer
needed.

Signed-off-by: Aleksandar Radovanovic <biblbroks@sezampro.rs>

SVN-Revision: 18725
2009-12-09 18:50:49 +00:00
Felix Fietkau
73723393f9 hotplug2: get rid of the unnecessary reference to libdl as well
SVN-Revision: 18106
2009-10-20 20:59:40 +00:00
Felix Fietkau
ebb1151032 hotplug2: compile in the worker module statically, saves >20k uncompressed
SVN-Revision: 18104
2009-10-20 20:49:44 +00:00
Felix Fietkau
47ba8235cd hotplug2: fix "MALLOC FAILURE!" message caused by a missing return code check on recv()
SVN-Revision: 18061
2009-10-19 02:39:02 +00:00
Hamish Guthrie
5513f6a9e9 Move hotplug2 v0.9 to hotplug2-old
SVN-Revision: 16135
2009-05-28 13:20:54 +00:00
John Crispin
863afccae8 remove warning from hotplug2, which pops up 10 times during boot
SVN-Revision: 12086
2008-08-04 08:04:16 +00:00
Felix Fietkau
c5ecc1790a fix hotplug2 event processing deadlock
when bringing up ethernet on ixp4xx, the driver may request
a firmware while hotplug2 waits for the netdev bringup to complete.
change the event processing loop to keep an event backlog to allow
unthrottled events to pass through while throttled events are being waited for

SVN-Revision: 12019
2008-07-30 19:02:01 +00:00
Felix Fietkau
fd5595ed5c fix two small bugs in the hotplug2 rule parser (#2085)
SVN-Revision: 8023
2007-07-18 07:23:40 +00:00
Felix Fietkau
0e387805fb hotplug2 update - include hotplug2-init.rules from hotplug2.rules, fix permissions of various devices (fixes #2052)
SVN-Revision: 7892
2007-07-09 00:13:47 +00:00
Felix Fietkau
c09dc20f2c replace the hotplug2 fork handling hack with a better solution implemented in upstream (thanks, iSteve)
SVN-Revision: 7786
2007-06-30 11:05:14 +00:00
Felix Fietkau
13f087cd5a hotplug2: add fork handling optimization (also fixes that pesky pppoe race condition in #1655)
SVN-Revision: 7726
2007-06-25 09:47:58 +00:00
Felix Fietkau
05c0ca34a7 update to hotplug2 svn version (recommended by iSteve)
SVN-Revision: 7725
2007-06-25 09:46:37 +00:00
Felix Fietkau
a99b79e9ad hotplug2: add a missing cflag, allow hotplug events that are not 'add'
SVN-Revision: 7721
2007-06-25 07:08:35 +00:00
Felix Fietkau
d309c4fa30 make hotplug2 use the build system cflags
SVN-Revision: 7720
2007-06-25 06:30:36 +00:00
Felix Fietkau
9114220553 refresh all package patches in the buildroot using quilt
SVN-Revision: 7490
2007-06-04 11:25:53 +00:00
Felix Fietkau
ca7a815602 use hotplug2 for serializing hotplug events on 2.6
SVN-Revision: 7097
2007-05-05 18:33:18 +00:00