KumiSystems/openwrtv4
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
22587 commits 3 branches 0 tags 154 MiB
Commit graph

7180 commits

Author SHA1 Message Date
Florian Fainelli
157cccaa6b package/kernel: snd-soc-core depends on regmap 
Signed-off-by: Florian Fainelli <florian@openwrt.org>

SVN-Revision: 34616
 2012-12-10 21:05:15 +00:00
Florian Fainelli
7685458982 package/kernel: package kmod-input-matrixkmap 
This is required by some keyboard drivers in 3.6+

Signed-off-by: Florian Fainelli <florian@openwrt.org>

SVN-Revision: 34614
 2012-12-10 21:05:06 +00:00
Felix Fietkau
1820e8566e kernel: include the xfrm_algo module on 3.6+ (fixes #12552) 
SVN-Revision: 34611
 2012-12-10 18:49:30 +00:00
Felix Fietkau
b8757c644f mac80211: fix channel context related warnings when using wds ap mode (fixes #12585) 
SVN-Revision: 34610
 2012-12-10 18:29:17 +00:00
Steven Barth
faba477274 ipv6-support: Add support for NPT status tracking 
SVN-Revision: 34609
 2012-12-10 16:46:59 +00:00
Steven Barth
cd76023e97 6distributed: add status-call for luci-integration 
SVN-Revision: 34608
 2012-12-10 16:46:54 +00:00
Felix Fietkau
e3128792fe b43: fix tx path skb leaks 
SVN-Revision: 34607
 2012-12-10 16:43:01 +00:00
Gabor Juhos
dfd718d13d mac80211: ath9k: allow to load EEPROM data via firmware API 
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>

SVN-Revision: 34606
 2012-12-10 15:46:15 +00:00
Gabor Juhos
0739a2bb9c mac80211: ath9k: fix OTP register offsets for AR9340 
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>

SVN-Revision: 34605
 2012-12-10 15:46:13 +00:00
Felix Fietkau
19fc506333 ath5k: fix skb leaks (should fix #12199) 
SVN-Revision: 34603
 2012-12-10 15:42:34 +00:00
Felix Fietkau
cb9c63048d mac80211: fix setting txpower (#12594) 
SVN-Revision: 34594
 2012-12-10 13:51:09 +00:00
Felix Fietkau
01513b7c8b iw: sync with nl80211.h to fix setting antenna gain 
SVN-Revision: 34593
 2012-12-10 13:51:06 +00:00
Felix Fietkau
8d15b064e0 ath9k: improve signal strength / channel noise reporting accuracy 
SVN-Revision: 34592
 2012-12-10 13:51:02 +00:00
Felix Fietkau
45a0216593 mac80211: refresh patches 
SVN-Revision: 34591
 2012-12-10 13:50:58 +00:00
Felix Fietkau
77c14b1a99 mac80211: merge fix for carl9170 upstream regression 
SVN-Revision: 34590
 2012-12-10 13:50:54 +00:00
Steven Barth
a07ddb955f ipv6-support: Next iteration * Make ula_prefix a global option * Add preliminary support for NAT (Linux >= 3.7, ip6tables >= 1.4.17) * Minor fixes for prefix fallback 
SVN-Revision: 34586
 2012-12-09 13:54:22 +00:00
Steven Barth
57d853ffc4 6distributed: Correctly handle duplicate prefixes 
SVN-Revision: 34585
 2012-12-09 13:32:30 +00:00
Steven Barth
eeeb59e451 6relayd: Always send NA with hop-limit 255 * thanks risa2000 for investigating 
SVN-Revision: 34584
 2012-12-09 12:33:28 +00:00
Hauke Mehrtens
a087cde13e mac80211: do not build mwifiex driver 
SVN-Revision: 34573
 2012-12-07 18:10:14 +00:00
Felix Fietkau
6716ba9aad mac80211: update to wireless-testing 2012-12-06 
SVN-Revision: 34571
 2012-12-07 16:46:04 +00:00
Hauke Mehrtens
3365e2caf0 mac80211: brcmsmac: do a read after write when writing objmem to device. 
SVN-Revision: 34570
 2012-12-07 16:24:35 +00:00
Jo-Philipp Wich
16d0957a4e firewall: fix typo in reflection hotplug script 
SVN-Revision: 34569
 2012-12-07 13:08:28 +00:00
Steven Barth
63135142d8 6to4: Remove static radvd-integration * Please use the new ipv6-support package 
SVN-Revision: 34567
 2012-12-07 08:53:53 +00:00
Florian Fainelli
5679d5d1e1 mac80211: add support for adm8211 wireless driver 
Signed-off-by: Florian Fainelli <florian@openwrt.org>

SVN-Revision: 34560
 2012-12-06 22:40:45 +00:00
Steven Barth
82576f0ca3 ipv6-support: next iteration * Introduce mode 6rd * Introduce mode 6to4 * Fix announcement of DNS-Servers received from DHCPv6 * Fix some corner-cases in relaying behaviour 
SVN-Revision: 34542
 2012-12-06 20:52:40 +00:00
Steven Barth
61e8c6b83b 6relayd: More RFC-compatibility and size reduction 
SVN-Revision: 34541
 2012-12-06 20:52:35 +00:00
Steven Barth
f14e1f1b1d 6distributed: Add compatibility with 6rd and 6to4 
SVN-Revision: 34540
 2012-12-06 20:52:30 +00:00
Jo-Philipp Wich
d221222907 ppp: unconditionally start pppd with nodefaultroute and usepeerdns (#12580) 
Since the switch to netifd, proto handlers may always set the defaultroute
and provide dns server addresses, netifd will decide in the generic code
path whether the announced values are masked or not.

Additionally protocol handlers should not modify the routing tables themselves
and prevent any launched services from doing so.

Remove the additional defaultroute and peerdns option handling from the ppp.sh
protocol handler and rely on netifd to mask or not mask the values.

SVN-Revision: 34536
 2012-12-06 18:17:21 +00:00
Felix Fietkau
94c1d77886 kernel: fix video-core build on 3.6+ 
SVN-Revision: 34533
 2012-12-06 14:11:19 +00:00
Felix Fietkau
3e5940532d mac80211: clean up patches, replace patching config.mk with a generated sed expression 
SVN-Revision: 34531
 2012-12-06 14:11:09 +00:00
Florian Fainelli
85ce5212fe libiconv-full: add clause to Makefile to actually install iconv 
At present, if you select the iconv utility it will be built but not
installed. This patch adds the clauses necessary to the Makefile to
actually install iconv.

Signed-off-by: Mike Brady <mikebrady@eircom.net>
Signed-off-by: Florian Fainelli <florian@openwrt.org>

SVN-Revision: 34530
 2012-12-05 18:05:04 +00:00
Florian Fainelli
eaa30e9776 linux-atm: put all packages into their own submenus 
Now that we package individual tools as well, the list of ATM tools is
pretty big to deserve its own submenu.

Signed-off-by: Florian Fainelli <florian@openwrt.org>

SVN-Revision: 34504
 2012-12-05 14:58:54 +00:00
Florian Fainelli
da069ac466 linux-atm: fix typo introduced in r34502 
Signed-off-by: Florian Fainelli <florian@openwrt.org>

SVN-Revision: 34503
 2012-12-05 14:37:03 +00:00
Florian Fainelli
b459e36579 linux-atm: package each available atm debug tool individually 
Signed-off-by: Florian Fainelli <florian@openwrt.org>

SVN-Revision: 34502
 2012-12-05 14:18:08 +00:00
Felix Fietkau
838d6e3b8d netifd: update to latest version, fixes resolv.conf writes on interface setting changes 
SVN-Revision: 34500
 2012-12-05 13:28:56 +00:00
Florian Fainelli
9e355444a6 dropbear: update to 2012.55 and refresh patches 
Upstream has a few code cleanups, more eagerly burns sensitive memory and
includes the fix for CVE-2012-0920. Full changelog:
https://matt.ucc.asn.au/dropbear/CHANGES

Local changes:
- Removed PKG_MULTI which is no longer in options.h (even before 2011.54)
- Merged DO_HOST_LOOKUP into 120-openwrt_options.patch
- Removed LD from make opts (now included in TARGET_CONFIGURE_OPTS)
- Removed 400-CVE-2012-0920.patch which is included in 2012.55

Signed-off-by: Catalin Patulea <cat@vv.carleton.ca>
Signed-off-by: Florian Fainelli <florian@openwrt.org>

SVN-Revision: 34496
 2012-12-04 16:40:17 +00:00
Florian Fainelli
4f78be25e1 linux-atm: create atm-debug-tools package 
Instead of commenting the inclusion of some binaries, just make them
available using a new package "atm-debug-tools."

Signed-off-by: Florian Fainelli <florian@openwrt.org>

SVN-Revision: 34477
 2012-12-04 16:19:24 +00:00
Florian Fainelli
250773ef32 linux-atm: factor common descriptions 
Signed-off-by: Florian Fainelli <florian@openwrt.org>

SVN-Revision: 34476
 2012-12-04 16:19:21 +00:00
Jo-Philipp Wich
6504b268b3 firewall: extend nat reflection support 
- use comment match to keep track of per-network rules
	- setup reflection for any interface which is part of a masqueraded zone, not just "wan"
	- delete per-network reflection rules if network is brought down

SVN-Revision: 34472
 2012-12-04 15:24:21 +00:00
Felix Fietkau
8516ddb133 mac80211, hostapd: Fix macfilter for multi bssid setups 
Previously only the first macfilter configuration would have been used
on all interfaces. However, the configuration was always done per vif
already. Hence, move the macfilter setup into hostapd.sh where and
create one mac list file per vif.

Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>

SVN-Revision: 34470
 2012-12-04 12:06:40 +00:00
Mirko Vogt
4c30952394 Make ltq-dsl-app compile with an eglibc-based toolchain 
Signed-Off-By: Frank Meerkötter <frank@meerkoetter.org>

SVN-Revision: 34468
 2012-12-03 12:46:57 +00:00
Steven Barth
4bda16cf27 ipv6-support: Second Iteration * mode 'downstream' renamed to 'router' * mode 'upstream' renamed to 'dhcpv6' * mode 'relay' added * cleanups and minor bugfixes in state handling 
SVN-Revision: 34466
 2012-12-03 09:18:53 +00:00
Steven Barth
71ed7ae842 netifd: empty hotplug handler removed 
SVN-Revision: 34465
 2012-12-03 07:20:44 +00:00
Gabor Juhos
8cfe4bf9cd mac80211: refresh patches 
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>

SVN-Revision: 34464
 2012-12-02 20:41:39 +00:00
Gabor Juhos
7a26eb9f13 mac80211: rename a misnamed ath9k patch 
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>

SVN-Revision: 34463
 2012-12-02 20:41:37 +00:00
Steven Barth
c6b0c63cad 6distributed: Poll for ubus to come up (fix race) 
SVN-Revision: 34462
 2012-12-02 19:06:48 +00:00
Felix Fietkau
d38be845f4 libubox: update to latest version, fixes blob/blobmsg endian issues 
SVN-Revision: 34456
 2012-12-02 16:50:39 +00:00
Hauke Mehrtens
3399d16dd7 broadcom-wl: get the mmio address directly from the struct if bcma is used. 
SVN-Revision: 34452
 2012-12-02 16:07:43 +00:00
Gabor Juhos
5d8a7a0ce5 Make teql hotplug script run sooner 
In particular, it wants to run before the ntpclient script. Which may
block for a long time attempting to do DNS lookups for NTP servers. In
my case, that would have *worked* if the new device had been added to
teql first, rather than timing out.

This was effectively causing a huge delay between an interface coming
up, and routing actually starting to work.

Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>

SVN-Revision: 34442
 2012-12-02 13:04:03 +00:00
Jo-Philipp Wich
a99b0363d0 package: use file_copy to deploy files/ in the package/install phase 
SVN-Revision: 34438
 2012-12-02 12:20:38 +00:00
Florian Fainelli
4a1e2123eb kernel: remove references to TARGET_ubicom32 
Signed-off-by: Florian Fainelli <florian@openwrt.org>

SVN-Revision: 34431
 2012-11-30 10:53:51 +00:00
Steven Barth
a0f0c23109 ipv6-support: Add conffiles section 
SVN-Revision: 34423
 2012-11-29 20:33:17 +00:00
Steven Barth
a4edea5ef3 ipv6-support: Add new IPv6-support meta-package 
SVN-Revision: 34422
 2012-11-29 20:14:28 +00:00
Steven Barth
e6e6e0d152 odhcp6c: Add new embedded DHCPv6 client 
SVN-Revision: 34421
 2012-11-29 20:14:23 +00:00
Steven Barth
25d943e872 6distributed: add local IPv6 prefix distributor 
SVN-Revision: 34420
 2012-11-29 20:14:18 +00:00
Steven Barth
7d3495b431 6relayd: Fix some RFC 6204 compatibility issues 
SVN-Revision: 34419
 2012-11-29 20:14:14 +00:00
Steven Barth
dffa972af1 Remove old IPv6 sysctl-config (deprecated) 
SVN-Revision: 34418
 2012-11-29 20:14:09 +00:00
Steven Barth
3b0e77ee6b Remove default sysctl-entry for IPv6 here (races) 
SVN-Revision: 34417
 2012-11-29 20:14:04 +00:00
Luka Perkov
769c322cd0 uboot-kirkwood: build in $(BUILD_DIR) 
SVN-Revision: 34401
 2012-11-29 01:04:37 +00:00
Jo-Philipp Wich
d2d458324b gettext-full: use shipped libxml for the host build, fixes lzma references from creeping in on certain distributions 
SVN-Revision: 34400
 2012-11-28 21:02:53 +00:00
Jo-Philipp Wich
32dcd5d6c7 trace-cmd: lazily evaluate extra plugins list, fixes stray build errors causing by missing operands to cp if the package was never built yet 
SVN-Revision: 34390
 2012-11-27 18:08:42 +00:00
Jo-Philipp Wich
78cec2cfca grub2: fix another case of gnulib failing under gnu libc 
SVN-Revision: 34389
 2012-11-26 16:03:40 +00:00
Hauke Mehrtens
e9b6c999f5 broadcom-wl: fix two problems when more then one wifi card is available. 
* The device should get a unique name at the beginning and not wl%d.
* load the nvram just one time into the own buffer, also when there is
  more than one device.

SVN-Revision: 34381
 2012-11-25 20:11:15 +00:00
Gabor Juhos
38fced86ee base-files: add support for the morse LED trigger 
Write "delay" and "message" options to their respective files,
allowing Morse code message configuration through UCI.
The delay (dit length) defaults to 150ms (about 8 words per minute,
suitable for beginners).

Signed-off-by: Petr Viktorin <encukou@gmail.com>
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>

SVN-Revision: 34380
 2012-11-25 17:20:49 +00:00
Florian Fainelli
203cbbd51d modules: remove obsolete comment (#12514) 
Signed-off-by: Florian Fainelli <florian@openwrt.org>

SVN-Revision: 34327
 2012-11-25 11:41:07 +00:00
Florian Fainelli
062d3c1e67 iptables: fix typo in iptables musl patch after r34313 
Thanks to Frank Meerkötter and Szabolcs Nagy for spotting the issue.

Signed-off-by: Florian Fainelli <florian@openwrt.org>

SVN-Revision: 34326
 2012-11-25 11:40:59 +00:00
Florian Fainelli
6b63716262 add preliminary support for musl 
Musl is an alternative C-library, see http://www.musl-libc.org for more infos.

Signed-off-by: Florian Fainelli <florian@openwrt.org>

SVN-Revision: 34314
 2012-11-23 20:02:29 +00:00
Florian Fainelli
14ed3f0f22 iptables: add some musl portability fixes 
Signed-off-by: Florian Fainelli <florian@openwrt.org>

SVN-Revision: 34313
 2012-11-23 20:02:23 +00:00
Florian Fainelli
ba6c8bd614 linux-atm: add portability fixes 
Spotted while building against musl libc.

Signed-off-by: Florian Fainelli <florian@openwrt.org>

SVN-Revision: 34312
 2012-11-23 20:02:19 +00:00
Florian Fainelli
92fd6e6f1a busybox: fix arping applet building on musl 
musl-libc is more strict about missing includes.

Signed-off-by: Florian Fainelli <florian@openwrt.org>

SVN-Revision: 34311
 2012-11-23 20:02:14 +00:00
Florian Fainelli
94bdc366d4 netfid: fix build on musl 
AF_INET* is provided by sys/socket.h

Signed-off-by: Florian Fainelli <florian@openwrt.org>

SVN-Revision: 34310
 2012-11-23 20:02:10 +00:00
Florian Fainelli
7c26e53d5d busybox: define musl specificities in platform.h 
Signed-off-by: Florian Fainelli <florian@openwrt.org>

SVN-Revision: 34309
 2012-11-23 20:02:06 +00:00
Florian Fainelli
5ae2524d3a base-files: use a natural mount syntax 
Busybox built against musl-libc will choke on these otherwise, besides that
it is more natural to use the filesystem type, then options, then name, then
mountpoint.

Signed-off-by: Florian Fainelli <florian@openwrt.org>

SVN-Revision: 34308
 2012-11-23 20:02:02 +00:00
Florian Fainelli
bc8fe9b40f busybox: change the date -k patch to be more portable 
Not all libcs have support for tm_gmtoff which is only available for BSD
compatibility, and guarded with __USE_BSD defines, use __tm_gmtoff otherwise.

Signed-off-by: Florian Fainelli <florian@openwrt.org>

SVN-Revision: 34307
 2012-11-23 20:01:58 +00:00
Florian Fainelli
49cfa54509 grub2: accept the linux-musl* tuple 
Signed-off-by: Florian Fainelli <florian@openwrt.org>

SVN-Revision: 34306
 2012-11-23 20:01:53 +00:00
Luka Perkov
6db1b986ed uboot-lantiq: add new package 
SVN-Revision: 34305
 2012-11-23 18:16:05 +00:00
Luka Perkov
702f2590ea uboot-kirkwood: update to 2012.10 
SVN-Revision: 34303
 2012-11-22 21:16:04 +00:00
Jonas Gorski
24a372b6ec package: kernel: make crypto kmods always visible 
Don't hide crypo submodules unless crypo-core is selected.

Fixes kmods depending on crypto modules being unselectable
until crypto core is selected (like ext4 on 3.6 or mac80211).

Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>

SVN-Revision: 34298
 2012-11-22 11:55:18 +00:00
Florian Fainelli
f1498531c7 hostapd: include sys/stat.h for a struct stat definition 
Some libcs need this header to be explicitely included (e.g: musl)

Signed-off-by: Florian Fainelli <florian@openwrt.org>

SVN-Revision: 34295
 2012-11-21 20:27:06 +00:00
Florian Fainelli
7453b0dd8e mtd: do not include error.h 
We do not use anything from it, and it is not available with all libcs.
Signed-off-by: Florian Fainelli <florian@openwrt.org>

SVN-Revision: 34294
 2012-11-21 20:27:02 +00:00
Florian Fainelli
3df1f9aecd valgrind: re-categorize from utils to devel 
Signed-off-by: Florian Fainelli <florian@openwrt.org>

SVN-Revision: 34293
 2012-11-21 20:26:58 +00:00
Florian Fainelli
4e733cfbc9 libthread-db: fix libthread_db.so installation. 
libthread_db.so.$(LIBC_SO_VERSION) is only valid for uClibc, (e)glibc just
provides libthread_db.so.1.

Signed-off-by: Florian Fainelli <florian@openwrt.org>

SVN-Revision: 34292
 2012-11-21 20:26:55 +00:00
Florian Fainelli
e5effc8c4c gdb: recategorize from utils to devel in menuconfig 
Signed-off-by: Florian Fainelli <florian@openwrt.org>

SVN-Revision: 34291
 2012-11-21 20:26:51 +00:00
John Crispin
0ae8453c71 actually deploy atmarp and atmarpd and not just their libtool wrapper 
due to a small error in the atm-tools package we are not deploying
atmarp/atmarpd but instead the (useless) libtool-wrappers.

Signed-Off-By: Frank Meerkötter <frank@meerkoetter.org>

SVN-Revision: 34287
 2012-11-21 06:07:23 +00:00
Gabor Juhos
6c1fbb2d5c mac80211/rt2x00: add rf_vals for Rt3352 with Xtal=20MHz 
[juhosg: move ramips specific stuff into a followup patch]

Signed-off-by: Daniel Golle <dgolle@allnet.de>
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>

SVN-Revision: 34269
 2012-11-20 07:19:09 +00:00
Gabor Juhos
a2e71a0bbf mac80211/rt2x00: support Rt3352 with external PA 
This is needed for WiFi to work e.g. on DIR-615 rev.H1.

Signed-off-by: Daniel Golle <dgolle@allnet.de>
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>

SVN-Revision: 34268
 2012-11-20 07:19:08 +00:00
Florian Fainelli
8ca4fd7ad1 gdb: fix debugging of MIPS(el) applications 
GDB previously failed with the following:

root@OpenWrt:/# gdb busybox
[snip]
(gdb) r
Starting program: /bin/busybox
GDB bug: target.c (gdb_signal_from_host): unrecognized real-time signal

Signed-off-by: Florian Fainelli <florian@openwrt.org>

SVN-Revision: 34258
 2012-11-19 14:38:02 +00:00
Florian Fainelli
3c1642a9e1 gdb: add missing zlib dependency 
Signed-off-by: Florian Fainelli <florian@openwrt.org>

SVN-Revision: 34256
 2012-11-19 14:37:22 +00:00
Hauke Mehrtens
86cc79ac98 brcm47xx: add support for kernel 3.6 
This is based on the patch by Peter Wagner.

SVN-Revision: 34252
 2012-11-18 21:27:00 +00:00
Imre Kaloz
d0226aff1d shouldn't use kernel headers from userspace 
SVN-Revision: 34246
 2012-11-18 18:29:58 +00:00
Gabor Juhos
21393323d0 package/uboot-envtools: add OpenMesh MR600 support 
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>

SVN-Revision: 34236
 2012-11-18 09:32:40 +00:00
Steven Barth
417af03ba5 6relayd: add conffiles section, thanks swalker 
SVN-Revision: 34222
 2012-11-17 09:44:41 +00:00
Florian Fainelli
968c77147c ar7-atm: make it depend on the generic AR7 platform 
Signed-off-by: Florian Fainelli <florian@openwrt.org>

SVN-Revision: 34205
 2012-11-16 13:00:41 +00:00
Steven Barth
45137b0896 6relayd: various updates & fixes - Add RD- and DHCPv6-server functionality - Rework configuration and add example UCI file - Fix various bugs and be more RFC compliant 
SVN-Revision: 34204
 2012-11-16 09:27:56 +00:00
Jo-Philipp Wich
24b102fc3c opkg: fix find logic introduced by previous commit 
SVN-Revision: 34203
 2012-11-15 20:53:51 +00:00
Jo-Philipp Wich
ede4e23677 opkg: various additions - only wrap package descriptions when outputting to a tty, simplifies parsing descriptions with external utils - introduce -i (--nocase) flag which makes all matching operations case insensitive - introduce "find" command which searches package names and descriptions (e.g. opkg -i find "*autoconfig*") 
SVN-Revision: 34202
 2012-11-15 20:17:49 +00:00
Jo-Philipp Wich
db207e2a87 ppp: - fix multilink ppp with custom ifnames, patch by George Kashperko <george@znau.edu.ua> - refresh patches 
SVN-Revision: 34171
 2012-11-12 19:13:45 +00:00
Jonas Gorski
c0eb827265 kernel: modules: ext4 depends on crypto-hash on 3.6 
SVN-Revision: 34159
 2012-11-11 19:42:35 +00:00
Florian Fainelli
ae912505ac i2c-gpio-mux: fix build for 3.6+ kernels 
Signed-off-by: Florian Fainelli <florian@openwrt.org>

SVN-Revision: 34152
 2012-11-11 18:40:43 +00:00
Felix Fietkau
f9e59cf29c mac80211: add more tx skb free fixes (hopefully final fix to #11894) 
SVN-Revision: 34133
 2012-11-10 02:47:33 +00:00