KumiSystems/openwrtv4
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

staging: mt7621-eth: fix return value check in mtk_probe()

Browse source 
In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Fixes: e3cbf478f846 ("staging: mt7621-eth: add the drivers core files")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Wei Yongjun 2018-05-14 11:14:23 -07:00 committed by John Crispin
parent e07baec9fa
commit c4ae54dfab
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
target/linux/ramips/files-4.14/drivers/net/ethernet/mtk/mtk_eth_soc.c
View file

@ -1513,7 +1513,7 @@ static int fe_probe(struct platform_device *pdev)
soc->reg_table = fe_reg_table; soc->reg_table = fe_reg_table;
fe_base = devm_ioremap_resource(&pdev->dev, res); fe_base = devm_ioremap_resource(&pdev->dev, res);
if (!fe_base) { if (IS_ERR(fe_base)) {
err = -EADDRNOTAVAIL; err = -EADDRNOTAVAIL;
goto err_out; goto err_out;
} }