KumiSystems/openwrtv4
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

generic: make switch_port_stats tx/rx_bytes long long

Browse source 
This generic structure defines tx_bytes and rx_bytes as unsigned long (u32),
while several devices would typically report unsigned long long (u64).

The code can work as is, but there's a chance that with a sufficiently fast
interface the overflow might happen too fast to be correctly noticed by the
consumers of this data.

This patch makes both field unsigned long long and updates the only known
consumer of this data: swconfig_leds.c

Signed-off-by: Thibaut VARENE <hacks@slashdirt.org>
This commit is contained in:
Thibaut VARENE 2017-08-04 12:32:04 +02:00 committed by John Crispin
parent 0369e35891
commit c30a70fc9f
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
target/linux/generic/files/drivers/net/phy/swconfig_leds.c
View file

@ -36,7 +36,7 @@ struct switch_led_trigger {
struct delayed_work sw_led_work; struct delayed_work sw_led_work;
u32 port_mask; u32 port_mask;
u32 port_link; u32 port_link;
unsigned long port_traffic[SWCONFIG_LED_NUM_PORTS]; unsigned long long port_traffic[SWCONFIG_LED_NUM_PORTS];
u8 link_speed[SWCONFIG_LED_NUM_PORTS]; u8 link_speed[SWCONFIG_LED_NUM_PORTS];
}; };

4
target/linux/generic/files/include/linux/switch.h
View file

@ -59,8 +59,8 @@ struct switch_port_link {
}; };
struct switch_port_stats { struct switch_port_stats {
unsigned long tx_bytes; unsigned long long tx_bytes;
unsigned long rx_bytes; unsigned long long rx_bytes;
}; };
/** /**