KumiSystems/openwrtv4
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

ag71xx: Move timestamp struct member outside of struct.

Browse source 
With this change, the timestamp variable is only used in ag71xx_check_dma_stuck. Small tx speedup.

Based on a Qualcomm commit. ag->timestamp = jiffies was not replaced with netif_trans_update(dev) because of this quote:

It should be noted that after this series several instances
of netif_trans_update() are useless (if they occur in
.ndo_start_xmit and driver doesn't set LLTX flag -- stack already
did an update).

From: http://lists.openwall.net/netdev/2016/05/03/87

Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev 2018-02-07 13:57:30 -08:00 committed by Felix Fietkau
parent 83d8df1ea2
commit 810659a22c
2 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx.h
View file

@ -169,8 +169,6 @@ struct ag71xx {
struct napi_struct napi; struct napi_struct napi;
u32 msg_enable; u32 msg_enable;
unsigned long timestamp;
/* /*
* From this point onwards we're not looking at per-packet fields. * From this point onwards we're not looking at per-packet fields.
*/ */

5
target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c
View file

@ -816,7 +816,6 @@ static netdev_tx_t ag71xx_hard_start_xmit(struct sk_buff *skb,
i = (ring->curr + n - 1) & ring_mask; i = (ring->curr + n - 1) & ring_mask;
ring->buf[i].len = skb->len; ring->buf[i].len = skb->len;
ring->buf[i].skb = skb; ring->buf[i].skb = skb;
ag->timestamp = jiffies;
netdev_sent_queue(dev, skb->len); netdev_sent_queue(dev, skb->len);
@ -928,9 +927,11 @@ static void ag71xx_restart_work_func(struct work_struct *work)
static bool ag71xx_check_dma_stuck(struct ag71xx *ag) static bool ag71xx_check_dma_stuck(struct ag71xx *ag)
{ {
unsigned long timestamp;
u32 rx_sm, tx_sm, rx_fd; u32 rx_sm, tx_sm, rx_fd;
if (likely(time_before(jiffies, ag->timestamp + HZ/10))) timestamp = netdev_get_tx_queue(ag->dev, 0)->trans_start;
if (likely(time_before(jiffies, timestamp + HZ/10)))
return false; return false;
if (!netif_carrier_ok(ag->dev)) if (!netif_carrier_ok(ag->dev))