From 7a5002ec9d67515cbeea99a89b94c70dc50456c4 Mon Sep 17 00:00:00 2001 From: Felix Fietkau Date: Sat, 25 Oct 2014 17:22:46 +0000 Subject: [PATCH] base-files: add /etc/shadow to list of essential files to keep in sysupgrade (bug 18206) Based on bug #18206 sysupgrade can lead to loss of password information in certain situations. Most likely all users who will upgrade from versions r43017-43040, will lose their current passwords. :-( https://dev.openwrt.org/ticket/18206 Currently /etc/shadow is defined as a conffile in base-files: https://dev.openwrt.org/browser/trunk/package/base-files/Makefile#L37 But it is not defined in the default list of essential files to keep in sysupgrade: https://dev.openwrt.org/browser/trunk/package/base-files/files/lib/upgrade/keep.d/base-files-essential If exporting conffiles info fails, /etc/shadow can get lost. Shadow passwords are now the default, so saying that preserving /etc/passwd is essential while /etc/shadow is not, makes no sense. The attached patch adds /etc/shadow to the list of essential files. Signed-off-by: Hannu Nyman SVN-Revision: 43061 --- package/base-files/files/lib/upgrade/keep.d/base-files-essential | 1 + 1 file changed, 1 insertion(+) diff --git a/package/base-files/files/lib/upgrade/keep.d/base-files-essential b/package/base-files/files/lib/upgrade/keep.d/base-files-essential index 2c611d29b4..978d4b58bc 100644 --- a/package/base-files/files/lib/upgrade/keep.d/base-files-essential +++ b/package/base-files/files/lib/upgrade/keep.d/base-files-essential @@ -4,6 +4,7 @@ /etc/group /etc/passwd /etc/profile +/etc/shadow /etc/shells /etc/sysctl.conf /etc/rc.local