2016-12-02 10:50:26 +00:00
|
|
|
From 9f0245f4c5b19e0708891143438d93b876e48aca Mon Sep 17 00:00:00 2001
|
2016-04-07 19:25:10 +00:00
|
|
|
From: Phil Elwell <phil@raspberrypi.org>
|
|
|
|
|
Date: Wed, 23 Mar 2016 20:53:47 +0000
|
2016-09-10 12:54:26 +00:00
|
|
|
Subject: [PATCH] vchiq_arm: Service callbacks must not fail
|
2016-04-07 19:25:10 +00:00
|
|
|
|
|
|
|
|
Service callbacks are not allowed to return an error. The internal callback
|
|
|
|
|
that delivers events and messages to user tasks does not enqueue them if
|
|
|
|
|
the service is closing, but this is not an error and should not be
|
|
|
|
|
reported as such.
|
|
|
|
|
|
|
|
|
|
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
|
|
|
|
|
---
|
|
|
|
|
drivers/misc/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +-
|
|
|
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
|
|
|
|
|
|
--- a/drivers/misc/vc04_services/interface/vchiq_arm/vchiq_arm.c
|
|
|
|
|
+++ b/drivers/misc/vc04_services/interface/vchiq_arm/vchiq_arm.c
|
|
|
|
|
@@ -224,7 +224,7 @@ add_completion(VCHIQ_INSTANCE_T instance
|
|
|
|
|
} else if (instance->closing) {
|
|
|
|
|
vchiq_log_info(vchiq_arm_log_level,
|
|
|
|
|
"service_callback closing");
|
|
|
|
|
- return VCHIQ_ERROR;
|
|
|
|
|
+ return VCHIQ_SUCCESS;
|
|
|
|
|
}
|
|
|
|
|
DEBUG_TRACE(SERVICE_CALLBACK_LINE);
|
|
|
|
|
}
|
