33 lines
1 KiB
Diff
33 lines
1 KiB
Diff
|
From d94da02421c14fa9295feb218cd45fc01d0f470b Mon Sep 17 00:00:00 2001
|
||
|
|
From: John Crispin <blogic@openwrt.org>
|
||
|
|
Date: Thu, 8 Aug 2013 17:19:42 +0200
|
||
|
|
Subject: [PATCH 08/25] serial: MIPS: lantiq: fix clock error check
|
||
|
|
|
||
|
|
The clk should be checked with the proper IS_ERR() api before accessing it.
|
||
|
|
|
||
|
|
Signed-off-by: John Crispin <blogic@openwrt.org>
|
||
|
|
---
|
||
|
|
drivers/tty/serial/lantiq.c | 4 ++--
|
||
|
|
1 file changed, 2 insertions(+), 2 deletions(-)
|
||
|
|
|
||
|
|
--- a/drivers/tty/serial/lantiq.c
|
||
|
|
+++ b/drivers/tty/serial/lantiq.c
|
||
|
|
@@ -318,7 +318,7 @@ lqasc_startup(struct uart_port *port)
|
||
|
|
struct ltq_uart_port *ltq_port = to_ltq_uart_port(port);
|
||
|
|
int retval;
|
||
|
|
|
||
|
|
- if (ltq_port->clk)
|
||
|
|
+ if (!IS_ERR(ltq_port->clk))
|
||
|
|
clk_enable(ltq_port->clk);
|
||
|
|
port->uartclk = clk_get_rate(ltq_port->fpiclk);
|
||
|
|
|
||
|
|
@@ -386,7 +386,7 @@ lqasc_shutdown(struct uart_port *port)
|
||
|
|
port->membase + LTQ_ASC_RXFCON);
|
||
|
|
ltq_w32_mask(ASCTXFCON_TXFEN, ASCTXFCON_TXFFLU,
|
||
|
|
port->membase + LTQ_ASC_TXFCON);
|
||
|
|
- if (ltq_port->clk)
|
||
|
|
+ if (!IS_ERR(ltq_port->clk))
|
||
|
|
clk_disable(ltq_port->clk);
|
||
|
|
}
|
||
|
|
|