33 lines
1.4 KiB
Diff
33 lines
1.4 KiB
Diff
|
From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl>
|
||
|
|
Date: Mon, 7 Nov 2016 13:19:42 +0100
|
||
|
|
Subject: [PATCH] net: bgmac: fix reversed checks for clock control flag
|
||
|
|
|
||
|
|
This fixes regression introduced by patch adding feature flags. It was
|
||
|
|
already reported and patch followed (it got accepted) but it appears it
|
||
|
|
was incorrect. Instead of fixing reversed condition it broke a good one.
|
||
|
|
|
||
|
|
This patch was verified to actually fix SoC hanges caused by bgmac on
|
||
|
|
BCM47186B0.
|
||
|
|
|
||
|
|
Fixes: db791eb2970b ("net: ethernet: bgmac: convert to feature flags")
|
||
|
|
Fixes: 4af1474e6198 ("net: bgmac: Fix errant feature flag check")
|
||
|
|
Cc: Jon Mason <jon.mason@broadcom.com>
|
||
|
|
---
|
||
|
|
drivers/net/ethernet/broadcom/bgmac.c | 4 ++--
|
||
|
|
1 file changed, 2 insertions(+), 2 deletions(-)
|
||
|
|
|
||
|
|
--- a/drivers/net/ethernet/broadcom/bgmac.c
|
||
|
|
+++ b/drivers/net/ethernet/broadcom/bgmac.c
|
||
|
|
@@ -1046,9 +1046,9 @@ static void bgmac_enable(struct bgmac *b
|
||
|
|
|
||
|
|
mode = (bgmac_read(bgmac, BGMAC_DEV_STATUS) & BGMAC_DS_MM_MASK) >>
|
||
|
|
BGMAC_DS_MM_SHIFT;
|
||
|
|
- if (!(bgmac->feature_flags & BGMAC_FEAT_CLKCTLST) || mode != 0)
|
||
|
|
+ if (bgmac->feature_flags & BGMAC_FEAT_CLKCTLST || mode != 0)
|
||
|
|
bgmac_set(bgmac, BCMA_CLKCTLST, BCMA_CLKCTLST_FORCEHT);
|
||
|
|
- if (bgmac->feature_flags & BGMAC_FEAT_CLKCTLST && mode == 2)
|
||
|
|
+ if (!(bgmac->feature_flags & BGMAC_FEAT_CLKCTLST) && mode == 2)
|
||
|
|
bgmac_cco_ctl_maskset(bgmac, 1, ~0,
|
||
|
|
BGMAC_CHIPCTL_1_RXC_DLL_BYPASS);
|
||
|
|
|