KumiSystems/openwrtv4
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
openwrtv4/target/linux/generic/patches-3.18/660-fq_codel_defaults.patch

14 lines
386 B
Diff
Raw Normal View History

kernel: start working on 3.18 support This commit: 1) Copies 3.14 patches 2) Drops mainlined stuff 3) Modifies some patches to apply Signed-off-by: Rafał Miłecki <zajec5@gmail.com> SVN-Revision: 43093
2014-10-27 18:14:39 +00:00
--- a/net/sched/sch_fq_codel.c
+++ b/net/sched/sch_fq_codel.c
kernel: fq_codel match flows_cnt to limit sizing OpenWRT changed the default fq_codel sch->limit from 10240 to 1024, without also adjusting q->flows_cnt. Eric Dumazet explains below that you must also adjust the buckets (q->flows_cnt) for this not to break. Eric explains: Limit of 1024 packets and 1024 flows is not wise I think. (If all buckets are in use, each bucket has a virtual queue of 1 packet, which is almost the same than having no queue at all) I suggest to have at least 8 packets per bucket, to let Codel have a chance to trigger. So you could either reduce number of buckets to 128 (if memory is tight), or increase limit to 8192. flows_cnt is now set to 1024/8=128 Signed-off-by: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
2016-05-07 08:57:18 +00:00
@@ -387,8 +387,8 @@ static int fq_codel_init(struct Qdisc *s
kernel: start working on 3.18 support This commit: 1) Copies 3.14 patches 2) Drops mainlined stuff 3) Modifies some patches to apply Signed-off-by: Rafał Miłecki <zajec5@gmail.com> SVN-Revision: 43093
2014-10-27 18:14:39 +00:00
struct fq_codel_sched_data *q = qdisc_priv(sch);
int i;
- sch->limit = 10*1024;
kernel: fq_codel match flows_cnt to limit sizing OpenWRT changed the default fq_codel sch->limit from 10240 to 1024, without also adjusting q->flows_cnt. Eric Dumazet explains below that you must also adjust the buckets (q->flows_cnt) for this not to break. Eric explains: Limit of 1024 packets and 1024 flows is not wise I think. (If all buckets are in use, each bucket has a virtual queue of 1 packet, which is almost the same than having no queue at all) I suggest to have at least 8 packets per bucket, to let Codel have a chance to trigger. So you could either reduce number of buckets to 128 (if memory is tight), or increase limit to 8192. flows_cnt is now set to 1024/8=128 Signed-off-by: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
2016-05-07 08:57:18 +00:00
- q->flows_cnt = 1024;
kernel: start working on 3.18 support This commit: 1) Copies 3.14 patches 2) Drops mainlined stuff 3) Modifies some patches to apply Signed-off-by: Rafał Miłecki <zajec5@gmail.com> SVN-Revision: 43093
2014-10-27 18:14:39 +00:00
+ sch->limit = 1024;
kernel: fq_codel match flows_cnt to limit sizing OpenWRT changed the default fq_codel sch->limit from 10240 to 1024, without also adjusting q->flows_cnt. Eric Dumazet explains below that you must also adjust the buckets (q->flows_cnt) for this not to break. Eric explains: Limit of 1024 packets and 1024 flows is not wise I think. (If all buckets are in use, each bucket has a virtual queue of 1 packet, which is almost the same than having no queue at all) I suggest to have at least 8 packets per bucket, to let Codel have a chance to trigger. So you could either reduce number of buckets to 128 (if memory is tight), or increase limit to 8192. flows_cnt is now set to 1024/8=128 Signed-off-by: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
2016-05-07 08:57:18 +00:00
+ q->flows_cnt = 128;
kernel: revert fq_codel quantum override to prevent it from causing too much cpu load with higher speed (#21326) Signed-off-by: Felix Fietkau <nbd@openwrt.org> SVN-Revision: 47811
2015-12-08 00:14:41 +00:00
q->quantum = psched_mtu(qdisc_dev(sch));
kernel: start working on 3.18 support This commit: 1) Copies 3.14 patches 2) Drops mainlined stuff 3) Modifies some patches to apply Signed-off-by: Rafał Miłecki <zajec5@gmail.com> SVN-Revision: 43093
2014-10-27 18:14:39 +00:00
q->perturbation = prandom_u32();
kernel: fq_codel match flows_cnt to limit sizing OpenWRT changed the default fq_codel sch->limit from 10240 to 1024, without also adjusting q->flows_cnt. Eric Dumazet explains below that you must also adjust the buckets (q->flows_cnt) for this not to break. Eric explains: Limit of 1024 packets and 1024 flows is not wise I think. (If all buckets are in use, each bucket has a virtual queue of 1 packet, which is almost the same than having no queue at all) I suggest to have at least 8 packets per bucket, to let Codel have a chance to trigger. So you could either reduce number of buckets to 128 (if memory is tight), or increase limit to 8192. flows_cnt is now set to 1024/8=128 Signed-off-by: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
2016-05-07 08:57:18 +00:00
INIT_LIST_HEAD(&q->new_flows);
Reference in a new issue Copy permalink