2017-03-13 12:30:10 +00:00
|
|
|
From b9004f4fd23e4c614d71c972f3a9311665480e29 Mon Sep 17 00:00:00 2001
|
|
|
|
From: Andy Gross <agross@codeaurora.org>
|
|
|
|
Date: Thu, 9 Mar 2017 08:19:18 +0100
|
|
|
|
Subject: [PATCH 32/69] phy: add qcom dwc3 phy
|
|
|
|
|
|
|
|
Signed-off-by: Andy Gross <agross@codeaurora.org>
|
|
|
|
---
|
|
|
|
drivers/phy/Kconfig | 12 ++
|
|
|
|
drivers/phy/Makefile | 1 +
|
|
|
|
drivers/phy/phy-qcom-dwc3.c | 484 ++++++++++++++++++++++++++++++++++++++++++++
|
|
|
|
3 files changed, 497 insertions(+)
|
|
|
|
create mode 100644 drivers/phy/phy-qcom-dwc3.c
|
|
|
|
|
|
|
|
--- a/drivers/phy/Kconfig
|
|
|
|
+++ b/drivers/phy/Kconfig
|
|
|
|
@@ -489,4 +489,16 @@ config PHY_NS2_PCIE
|
|
|
|
help
|
|
|
|
Enable this to support the Broadcom Northstar2 PCIe PHY.
|
|
|
|
If unsure, say N.
|
|
|
|
+
|
|
|
|
+config PHY_QCOM_DWC3
|
|
|
|
+ tristate "QCOM DWC3 USB PHY support"
|
|
|
|
+ depends on ARCH_QCOM
|
|
|
|
+ depends on HAS_IOMEM
|
|
|
|
+ depends on OF
|
|
|
|
+ select GENERIC_PHY
|
|
|
|
+ help
|
|
|
|
+ This option enables support for the Synopsis PHYs present inside the
|
|
|
|
+ Qualcomm USB3.0 DWC3 controller. This driver supports both HS and SS
|
|
|
|
+ PHY controllers.
|
|
|
|
+
|
|
|
|
endmenu
|
|
|
|
--- a/drivers/phy/Makefile
|
|
|
|
+++ b/drivers/phy/Makefile
|
|
|
|
@@ -60,3 +60,4 @@ obj-$(CONFIG_PHY_PISTACHIO_USB) += phy-
|
|
|
|
obj-$(CONFIG_PHY_CYGNUS_PCIE) += phy-bcm-cygnus-pcie.o
|
|
|
|
obj-$(CONFIG_ARCH_TEGRA) += tegra/
|
|
|
|
obj-$(CONFIG_PHY_NS2_PCIE) += phy-bcm-ns2-pcie.o
|
|
|
|
+obj-$(CONFIG_PHY_QCOM_DWC3) += phy-qcom-dwc3.o
|
|
|
|
--- /dev/null
|
|
|
|
+++ b/drivers/phy/phy-qcom-dwc3.c
|
|
|
|
@@ -0,0 +1,484 @@
|
|
|
|
+/* Copyright (c) 2014-2015, Code Aurora Forum. All rights reserved.
|
|
|
|
+ *
|
|
|
|
+ * This program is free software; you can redistribute it and/or modify
|
|
|
|
+ * it under the terms of the GNU General Public License version 2 and
|
|
|
|
+ * only version 2 as published by the Free Software Foundation.
|
|
|
|
+ *
|
|
|
|
+* This program is distributed in the hope that it will be useful,
|
|
|
|
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
+* GNU General Public License for more details.
|
|
|
|
+*/
|
|
|
|
+
|
|
|
|
+#include <linux/clk.h>
|
|
|
|
+#include <linux/err.h>
|
|
|
|
+#include <linux/io.h>
|
|
|
|
+#include <linux/module.h>
|
|
|
|
+#include <linux/of.h>
|
|
|
|
+#include <linux/phy/phy.h>
|
|
|
|
+#include <linux/platform_device.h>
|
|
|
|
+#include <linux/delay.h>
|
|
|
|
+
|
|
|
|
+/**
|
|
|
|
+ * USB QSCRATCH Hardware registers
|
|
|
|
+ */
|
|
|
|
+#define QSCRATCH_GENERAL_CFG (0x08)
|
|
|
|
+#define HSUSB_PHY_CTRL_REG (0x10)
|
|
|
|
+
|
|
|
|
+/* PHY_CTRL_REG */
|
|
|
|
+#define HSUSB_CTRL_DMSEHV_CLAMP BIT(24)
|
|
|
|
+#define HSUSB_CTRL_USB2_SUSPEND BIT(23)
|
|
|
|
+#define HSUSB_CTRL_UTMI_CLK_EN BIT(21)
|
|
|
|
+#define HSUSB_CTRL_UTMI_OTG_VBUS_VALID BIT(20)
|
|
|
|
+#define HSUSB_CTRL_USE_CLKCORE BIT(18)
|
|
|
|
+#define HSUSB_CTRL_DPSEHV_CLAMP BIT(17)
|
|
|
|
+#define HSUSB_CTRL_COMMONONN BIT(11)
|
|
|
|
+#define HSUSB_CTRL_ID_HV_CLAMP BIT(9)
|
|
|
|
+#define HSUSB_CTRL_OTGSESSVLD_CLAMP BIT(8)
|
|
|
|
+#define HSUSB_CTRL_CLAMP_EN BIT(7)
|
|
|
|
+#define HSUSB_CTRL_RETENABLEN BIT(1)
|
|
|
|
+#define HSUSB_CTRL_POR BIT(0)
|
|
|
|
+
|
|
|
|
+/* QSCRATCH_GENERAL_CFG */
|
|
|
|
+#define HSUSB_GCFG_XHCI_REV BIT(2)
|
|
|
|
+
|
|
|
|
+/**
|
|
|
|
+ * USB QSCRATCH Hardware registers
|
|
|
|
+ */
|
|
|
|
+#define SSUSB_PHY_CTRL_REG (0x00)
|
|
|
|
+#define SSUSB_PHY_PARAM_CTRL_1 (0x04)
|
|
|
|
+#define SSUSB_PHY_PARAM_CTRL_2 (0x08)
|
|
|
|
+#define CR_PROTOCOL_DATA_IN_REG (0x0c)
|
|
|
|
+#define CR_PROTOCOL_DATA_OUT_REG (0x10)
|
|
|
|
+#define CR_PROTOCOL_CAP_ADDR_REG (0x14)
|
|
|
|
+#define CR_PROTOCOL_CAP_DATA_REG (0x18)
|
|
|
|
+#define CR_PROTOCOL_READ_REG (0x1c)
|
|
|
|
+#define CR_PROTOCOL_WRITE_REG (0x20)
|
|
|
|
+
|
|
|
|
+/* PHY_CTRL_REG */
|
|
|
|
+#define SSUSB_CTRL_REF_USE_PAD BIT(28)
|
|
|
|
+#define SSUSB_CTRL_TEST_POWERDOWN BIT(27)
|
|
|
|
+#define SSUSB_CTRL_LANE0_PWR_PRESENT BIT(24)
|
|
|
|
+#define SSUSB_CTRL_SS_PHY_EN BIT(8)
|
|
|
|
+#define SSUSB_CTRL_SS_PHY_RESET BIT(7)
|
|
|
|
+
|
|
|
|
+/* SSPHY control registers */
|
|
|
|
+#define SSPHY_CTRL_RX_OVRD_IN_HI(lane) (0x1006 + 0x100 * lane)
|
|
|
|
+#define SSPHY_CTRL_TX_OVRD_DRV_LO(lane) (0x1002 + 0x100 * lane)
|
|
|
|
+
|
|
|
|
+/* RX OVRD IN HI bits */
|
|
|
|
+#define RX_OVRD_IN_HI_RX_RESET_OVRD BIT(13)
|
|
|
|
+#define RX_OVRD_IN_HI_RX_RX_RESET BIT(12)
|
|
|
|
+#define RX_OVRD_IN_HI_RX_EQ_OVRD BIT(11)
|
|
|
|
+#define RX_OVRD_IN_HI_RX_EQ_MASK 0x0700
|
|
|
|
+#define RX_OVRD_IN_HI_RX_EQ_SHIFT 8
|
|
|
|
+#define RX_OVRD_IN_HI_RX_EQ_EN_OVRD BIT(7)
|
|
|
|
+#define RX_OVRD_IN_HI_RX_EQ_EN BIT(6)
|
|
|
|
+#define RX_OVRD_IN_HI_RX_LOS_FILTER_OVRD BIT(5)
|
|
|
|
+#define RX_OVRD_IN_HI_RX_LOS_FILTER_MASK 0x0018
|
|
|
|
+#define RX_OVRD_IN_HI_RX_RATE_OVRD BIT(2)
|
|
|
|
+#define RX_OVRD_IN_HI_RX_RATE_MASK 0x0003
|
|
|
|
+
|
|
|
|
+/* TX OVRD DRV LO register bits */
|
|
|
|
+#define TX_OVRD_DRV_LO_AMPLITUDE_MASK 0x007F
|
|
|
|
+#define TX_OVRD_DRV_LO_PREEMPH_MASK 0x3F80
|
|
|
|
+#define TX_OVRD_DRV_LO_PREEMPH_SHIFT 7
|
|
|
|
+#define TX_OVRD_DRV_LO_EN BIT(14)
|
|
|
|
+
|
|
|
|
+/* SS CAP register bits */
|
|
|
|
+#define SS_CR_CAP_ADDR_REG BIT(0)
|
|
|
|
+#define SS_CR_CAP_DATA_REG BIT(0)
|
|
|
|
+#define SS_CR_READ_REG BIT(0)
|
|
|
|
+#define SS_CR_WRITE_REG BIT(0)
|
|
|
|
+
|
|
|
|
+struct qcom_dwc3_usb_phy {
|
|
|
|
+ void __iomem *base;
|
|
|
|
+ struct device *dev;
|
|
|
|
+ struct clk *xo_clk;
|
|
|
|
+ struct clk *ref_clk;
|
|
|
|
+};
|
|
|
|
+
|
|
|
|
+struct qcom_dwc3_phy_drvdata {
|
|
|
|
+ struct phy_ops ops;
|
|
|
|
+ u32 clk_rate;
|
|
|
|
+};
|
|
|
|
+
|
|
|
|
+/**
|
|
|
|
+ * Write register and read back masked value to confirm it is written
|
|
|
|
+ *
|
|
|
|
+ * @base - QCOM DWC3 PHY base virtual address.
|
|
|
|
+ * @offset - register offset.
|
|
|
|
+ * @mask - register bitmask specifying what should be updated
|
|
|
|
+ * @val - value to write.
|
|
|
|
+ */
|
|
|
|
+static inline void qcom_dwc3_phy_write_readback(
|
|
|
|
+ struct qcom_dwc3_usb_phy *phy_dwc3, u32 offset,
|
|
|
|
+ const u32 mask, u32 val)
|
|
|
|
+{
|
|
|
|
+ u32 write_val, tmp = readl(phy_dwc3->base + offset);
|
|
|
|
+
|
|
|
|
+ tmp &= ~mask; /* retain other bits */
|
|
|
|
+ write_val = tmp | val;
|
|
|
|
+
|
|
|
|
+ writel(write_val, phy_dwc3->base + offset);
|
|
|
|
+
|
|
|
|
+ /* Read back to see if val was written */
|
|
|
|
+ tmp = readl(phy_dwc3->base + offset);
|
|
|
|
+ tmp &= mask; /* clear other bits */
|
|
|
|
+
|
|
|
|
+ if (tmp != val)
|
|
|
|
+ dev_err(phy_dwc3->dev, "write: %x to QSCRATCH: %x FAILED\n",
|
|
|
|
+ val, offset);
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
+static int wait_for_latch(void __iomem *addr)
|
|
|
|
+{
|
|
|
|
+ u32 retry = 10;
|
|
|
|
+
|
|
|
|
+ while (true) {
|
|
|
|
+ if (!readl(addr))
|
|
|
|
+ break;
|
|
|
|
+
|
|
|
|
+ if (--retry == 0)
|
|
|
|
+ return -ETIMEDOUT;
|
|
|
|
+
|
|
|
|
+ usleep_range(10, 20);
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ return 0;
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
+/**
|
|
|
|
+ * Write SSPHY register
|
|
|
|
+ *
|
|
|
|
+ * @base - QCOM DWC3 PHY base virtual address.
|
|
|
|
+ * @addr - SSPHY address to write.
|
|
|
|
+ * @val - value to write.
|
|
|
|
+ */
|
|
|
|
+static int qcom_dwc3_ss_write_phycreg(struct qcom_dwc3_usb_phy *phy_dwc3,
|
|
|
|
+ u32 addr, u32 val)
|
|
|
|
+{
|
|
|
|
+ int ret;
|
|
|
|
+
|
|
|
|
+ writel(addr, phy_dwc3->base + CR_PROTOCOL_DATA_IN_REG);
|
|
|
|
+ writel(SS_CR_CAP_ADDR_REG, phy_dwc3->base + CR_PROTOCOL_CAP_ADDR_REG);
|
|
|
|
+
|
|
|
|
+ ret = wait_for_latch(phy_dwc3->base + CR_PROTOCOL_CAP_ADDR_REG);
|
|
|
|
+ if (ret)
|
|
|
|
+ goto err_wait;
|
|
|
|
+
|
|
|
|
+ writel(val, phy_dwc3->base + CR_PROTOCOL_DATA_IN_REG);
|
|
|
|
+ writel(SS_CR_CAP_DATA_REG, phy_dwc3->base + CR_PROTOCOL_CAP_DATA_REG);
|
|
|
|
+
|
|
|
|
+ ret = wait_for_latch(phy_dwc3->base + CR_PROTOCOL_CAP_DATA_REG);
|
|
|
|
+ if (ret)
|
|
|
|
+ goto err_wait;
|
|
|
|
+
|
|
|
|
+ writel(SS_CR_WRITE_REG, phy_dwc3->base + CR_PROTOCOL_WRITE_REG);
|
|
|
|
+
|
|
|
|
+ ret = wait_for_latch(phy_dwc3->base + CR_PROTOCOL_WRITE_REG);
|
|
|
|
+
|
|
|
|
+err_wait:
|
|
|
|
+ if (ret)
|
|
|
|
+ dev_err(phy_dwc3->dev, "timeout waiting for latch\n");
|
|
|
|
+ return ret;
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
+/**
|
|
|
|
+ * Read SSPHY register.
|
|
|
|
+ *
|
|
|
|
+ * @base - QCOM DWC3 PHY base virtual address.
|
|
|
|
+ * @addr - SSPHY address to read.
|
|
|
|
+ */
|
|
|
|
+static int qcom_dwc3_ss_read_phycreg(void __iomem *base, u32 addr, u32 *val)
|
|
|
|
+{
|
|
|
|
+ int ret;
|
|
|
|
+
|
|
|
|
+ writel(addr, base + CR_PROTOCOL_DATA_IN_REG);
|
|
|
|
+ writel(SS_CR_CAP_ADDR_REG, base + CR_PROTOCOL_CAP_ADDR_REG);
|
|
|
|
+
|
|
|
|
+ ret = wait_for_latch(base + CR_PROTOCOL_CAP_ADDR_REG);
|
|
|
|
+ if (ret)
|
|
|
|
+ goto err_wait;
|
|
|
|
+
|
|
|
|
+ /*
|
|
|
|
+ * Due to hardware bug, first read of SSPHY register might be
|
|
|
|
+ * incorrect. Hence as workaround, SW should perform SSPHY register
|
|
|
|
+ * read twice, but use only second read and ignore first read.
|
|
|
|
+ */
|
|
|
|
+ writel(SS_CR_READ_REG, base + CR_PROTOCOL_READ_REG);
|
|
|
|
+
|
|
|
|
+ ret = wait_for_latch(base + CR_PROTOCOL_READ_REG);
|
|
|
|
+ if (ret)
|
|
|
|
+ goto err_wait;
|
|
|
|
+
|
|
|
|
+ /* throwaway read */
|
|
|
|
+ readl(base + CR_PROTOCOL_DATA_OUT_REG);
|
|
|
|
+
|
|
|
|
+ writel(SS_CR_READ_REG, base + CR_PROTOCOL_READ_REG);
|
|
|
|
+
|
|
|
|
+ ret = wait_for_latch(base + CR_PROTOCOL_READ_REG);
|
|
|
|
+ if (ret)
|
|
|
|
+ goto err_wait;
|
|
|
|
+
|
|
|
|
+ *val = readl(base + CR_PROTOCOL_DATA_OUT_REG);
|
|
|
|
+
|
|
|
|
+err_wait:
|
|
|
|
+ return ret;
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
+static int qcom_dwc3_phy_power_on(struct phy *phy)
|
|
|
|
+{
|
|
|
|
+ int ret;
|
|
|
|
+ struct qcom_dwc3_usb_phy *phy_dwc3 = phy_get_drvdata(phy);
|
|
|
|
+
|
|
|
|
+ ret = clk_prepare_enable(phy_dwc3->xo_clk);
|
|
|
|
+ if (ret)
|
|
|
|
+ return ret;
|
|
|
|
+
|
|
|
|
+ ret = clk_prepare_enable(phy_dwc3->ref_clk);
|
|
|
|
+ if (ret)
|
|
|
|
+ clk_disable_unprepare(phy_dwc3->xo_clk);
|
|
|
|
+
|
|
|
|
+ return ret;
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
+static int qcom_dwc3_phy_power_off(struct phy *phy)
|
|
|
|
+{
|
|
|
|
+ struct qcom_dwc3_usb_phy *phy_dwc3 = phy_get_drvdata(phy);
|
|
|
|
+
|
|
|
|
+ clk_disable_unprepare(phy_dwc3->ref_clk);
|
|
|
|
+ clk_disable_unprepare(phy_dwc3->xo_clk);
|
|
|
|
+
|
|
|
|
+ return 0;
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
+static int qcom_dwc3_hs_phy_init(struct phy *phy)
|
|
|
|
+{
|
|
|
|
+ struct qcom_dwc3_usb_phy *phy_dwc3 = phy_get_drvdata(phy);
|
|
|
|
+ u32 val;
|
|
|
|
+
|
|
|
|
+ /*
|
|
|
|
+ * HSPHY Initialization: Enable UTMI clock, select 19.2MHz fsel
|
|
|
|
+ * enable clamping, and disable RETENTION (power-on default is ENABLED)
|
|
|
|
+ */
|
|
|
|
+ val = HSUSB_CTRL_DPSEHV_CLAMP | HSUSB_CTRL_DMSEHV_CLAMP |
|
|
|
|
+ HSUSB_CTRL_RETENABLEN | HSUSB_CTRL_COMMONONN |
|
|
|
|
+ HSUSB_CTRL_OTGSESSVLD_CLAMP | HSUSB_CTRL_ID_HV_CLAMP |
|
|
|
|
+ HSUSB_CTRL_DPSEHV_CLAMP | HSUSB_CTRL_UTMI_OTG_VBUS_VALID |
|
|
|
|
+ HSUSB_CTRL_UTMI_CLK_EN | HSUSB_CTRL_CLAMP_EN | 0x70;
|
|
|
|
+
|
|
|
|
+ /* use core clock if external reference is not present */
|
|
|
|
+ if (!phy_dwc3->xo_clk)
|
|
|
|
+ val |= HSUSB_CTRL_USE_CLKCORE;
|
|
|
|
+
|
|
|
|
+ writel(val, phy_dwc3->base + HSUSB_PHY_CTRL_REG);
|
|
|
|
+ usleep_range(2000, 2200);
|
|
|
|
+
|
|
|
|
+ /* Disable (bypass) VBUS and ID filters */
|
|
|
|
+ writel(HSUSB_GCFG_XHCI_REV, phy_dwc3->base + QSCRATCH_GENERAL_CFG);
|
|
|
|
+
|
|
|
|
+ return 0;
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
+static int qcom_dwc3_ss_phy_init(struct phy *phy)
|
|
|
|
+{
|
|
|
|
+ struct qcom_dwc3_usb_phy *phy_dwc3 = phy_get_drvdata(phy);
|
|
|
|
+ int ret;
|
|
|
|
+ u32 data = 0;
|
|
|
|
+
|
|
|
|
+ /* reset phy */
|
|
|
|
+ data = readl(phy_dwc3->base + SSUSB_PHY_CTRL_REG);
|
|
|
|
+ writel(data | SSUSB_CTRL_SS_PHY_RESET,
|
|
|
|
+ phy_dwc3->base + SSUSB_PHY_CTRL_REG);
|
|
|
|
+ usleep_range(2000, 2200);
|
|
|
|
+ writel(data, phy_dwc3->base + SSUSB_PHY_CTRL_REG);
|
|
|
|
+
|
|
|
|
+ /* clear REF_PAD if we don't have XO clk */
|
|
|
|
+ if (!phy_dwc3->xo_clk)
|
|
|
|
+ data &= ~SSUSB_CTRL_REF_USE_PAD;
|
|
|
|
+ else
|
|
|
|
+ data |= SSUSB_CTRL_REF_USE_PAD;
|
|
|
|
+
|
|
|
|
+ writel(data, phy_dwc3->base + SSUSB_PHY_CTRL_REG);
|
|
|
|
+
|
|
|
|
+ /* wait for ref clk to become stable, this can take up to 30ms */
|
|
|
|
+ msleep(30);
|
|
|
|
+
|
|
|
|
+ data |= SSUSB_CTRL_SS_PHY_EN | SSUSB_CTRL_LANE0_PWR_PRESENT;
|
|
|
|
+ writel(data, phy_dwc3->base + SSUSB_PHY_CTRL_REG);
|
|
|
|
+
|
|
|
|
+ /*
|
|
|
|
+ * Fix RX Equalization setting as follows
|
|
|
|
+ * LANE0.RX_OVRD_IN_HI. RX_EQ_EN set to 0
|
|
|
|
+ * LANE0.RX_OVRD_IN_HI.RX_EQ_EN_OVRD set to 1
|
|
|
|
+ * LANE0.RX_OVRD_IN_HI.RX_EQ set to 3
|
|
|
|
+ * LANE0.RX_OVRD_IN_HI.RX_EQ_OVRD set to 1
|
|
|
|
+ */
|
|
|
|
+ ret = qcom_dwc3_ss_read_phycreg(phy_dwc3->base,
|
|
|
|
+ SSPHY_CTRL_RX_OVRD_IN_HI(0), &data);
|
|
|
|
+ if (ret)
|
|
|
|
+ goto err_phy_trans;
|
|
|
|
+
|
|
|
|
+ data &= ~RX_OVRD_IN_HI_RX_EQ_EN;
|
|
|
|
+ data |= RX_OVRD_IN_HI_RX_EQ_EN_OVRD;
|
|
|
|
+ data &= ~RX_OVRD_IN_HI_RX_EQ_MASK;
|
|
|
|
+ data |= 0x3 << RX_OVRD_IN_HI_RX_EQ_SHIFT;
|
|
|
|
+ data |= RX_OVRD_IN_HI_RX_EQ_OVRD;
|
|
|
|
+ ret = qcom_dwc3_ss_write_phycreg(phy_dwc3,
|
|
|
|
+ SSPHY_CTRL_RX_OVRD_IN_HI(0), data);
|
|
|
|
+ if (ret)
|
|
|
|
+ goto err_phy_trans;
|
|
|
|
+
|
|
|
|
+ /*
|
|
|
|
+ * Set EQ and TX launch amplitudes as follows
|
|
|
|
+ * LANE0.TX_OVRD_DRV_LO.PREEMPH set to 22
|
|
|
|
+ * LANE0.TX_OVRD_DRV_LO.AMPLITUDE set to 127
|
|
|
|
+ * LANE0.TX_OVRD_DRV_LO.EN set to 1.
|
|
|
|
+ */
|
|
|
|
+ ret = qcom_dwc3_ss_read_phycreg(phy_dwc3->base,
|
|
|
|
+ SSPHY_CTRL_TX_OVRD_DRV_LO(0), &data);
|
|
|
|
+ if (ret)
|
|
|
|
+ goto err_phy_trans;
|
|
|
|
+
|
|
|
|
+ data &= ~TX_OVRD_DRV_LO_PREEMPH_MASK;
|
|
|
|
+ data |= 0x16 << TX_OVRD_DRV_LO_PREEMPH_SHIFT;
|
|
|
|
+ data &= ~TX_OVRD_DRV_LO_AMPLITUDE_MASK;
|
|
|
|
+ data |= 0x7f;
|
|
|
|
+ data |= TX_OVRD_DRV_LO_EN;
|
|
|
|
+ ret = qcom_dwc3_ss_write_phycreg(phy_dwc3,
|
|
|
|
+ SSPHY_CTRL_TX_OVRD_DRV_LO(0), data);
|
|
|
|
+ if (ret)
|
|
|
|
+ goto err_phy_trans;
|
|
|
|
+
|
|
|
|
+ /*
|
|
|
|
+ * Set the QSCRATCH PHY_PARAM_CTRL1 parameters as follows
|
|
|
|
+ * TX_FULL_SWING [26:20] amplitude to 127
|
|
|
|
+ * TX_DEEMPH_3_5DB [13:8] to 22
|
|
|
|
+ * LOS_BIAS [2:0] to 0x5
|
|
|
|
+ */
|
|
|
|
+ qcom_dwc3_phy_write_readback(phy_dwc3, SSUSB_PHY_PARAM_CTRL_1,
|
|
|
|
+ 0x07f03f07, 0x07f01605);
|
|
|
|
+
|
|
|
|
+err_phy_trans:
|
|
|
|
+ return ret;
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
+static int qcom_dwc3_ss_phy_exit(struct phy *phy)
|
|
|
|
+{
|
|
|
|
+ struct qcom_dwc3_usb_phy *phy_dwc3 = phy_get_drvdata(phy);
|
|
|
|
+
|
|
|
|
+ /* Sequence to put SSPHY in low power state:
|
|
|
|
+ * 1. Clear REF_PHY_EN in PHY_CTRL_REG
|
|
|
|
+ * 2. Clear REF_USE_PAD in PHY_CTRL_REG
|
|
|
|
+ * 3. Set TEST_POWERED_DOWN in PHY_CTRL_REG to enable PHY retention
|
|
|
|
+ */
|
|
|
|
+ qcom_dwc3_phy_write_readback(phy_dwc3, SSUSB_PHY_CTRL_REG,
|
|
|
|
+ SSUSB_CTRL_SS_PHY_EN, 0x0);
|
|
|
|
+ qcom_dwc3_phy_write_readback(phy_dwc3, SSUSB_PHY_CTRL_REG,
|
|
|
|
+ SSUSB_CTRL_REF_USE_PAD, 0x0);
|
|
|
|
+ qcom_dwc3_phy_write_readback(phy_dwc3, SSUSB_PHY_CTRL_REG,
|
ipq8064: Fix dwc3 module unloading
Allow module unloading by fixing a mistake.
qcom_dwc3_phy_write_readback() is expecting (phy, offset, mask, value)
while the mistake was calling it with (phy, offset, value, mask)
The patch is swapping value and mask.
Without the patch unloading the dwc3 module was showing a
write to QSCRATCH failed and repeated module loading was
failing:
root@LEDE:/# rmmod dwc3
[ 19.167998] xhci-hcd xhci-hcd.1.auto: remove, state 1
[ 19.168084] usb usb4: USB disconnect, device number 1
[ 19.173371] xhci-hcd xhci-hcd.1.auto: USB bus 4 deregistered
[ 19.177134] xhci-hcd xhci-hcd.1.auto: remove, state 1
[ 19.182960] usb usb3: USB disconnect, device number 1
[ 19.189023] xhci-hcd xhci-hcd.1.auto: USB bus 3 deregistered
[ 19.192989] qcom-dwc3-usb-phy 110f8830.phy: write: 8000000 to QSCRATCH: 0 FAILED
[ 19.199064] xhci-hcd xhci-hcd.0.auto: remove, state 1
[ 19.205912] usb usb2: USB disconnect, device number 1
[ 19.211611] xhci-hcd xhci-hcd.0.auto: USB bus 2 deregistered
[ 19.215905] xhci-hcd xhci-hcd.0.auto: remove, state 1
[ 19.221751] usb usb1: USB disconnect, device number 1
[ 19.227307] xhci-hcd xhci-hcd.0.auto: USB bus 1 deregistered
[ 19.231795] qcom-dwc3-usb-phy 100f8830.phy: write: 8000000 to QSCRATCH: 0 FAILED
root@LEDE:/# modprobe dwc3
[ 29.583343] phy phy-100f8830.phy.4: phy init failed --> -110
[ 29.583399] dwc3 10000000.dwc3: failed to initialize core
[ 29.588169] dwc3: probe of 10000000.dwc3 failed with error -110
[ 29.652943] phy phy-110f8830.phy.2: phy init failed --> -110
[ 29.652988] dwc3 11000000.dwc3: failed to initialize core
[ 29.657735] dwc3: probe of 11000000.dwc3 failed with error -110
root@LEDE:/#
With patch repeated module unloading and loading is working good:
root@LEDE:/# rmmod dwc3
[ 22.622214] xhci-hcd xhci-hcd.1.auto: remove, state 1
[ 22.622298] usb usb4: USB disconnect, device number 1
[ 22.627401] xhci-hcd xhci-hcd.1.auto: USB bus 4 deregistered
[ 22.631492] xhci-hcd xhci-hcd.1.auto: remove, state 1
[ 22.637054] usb usb3: USB disconnect, device number 1
[ 22.643721] xhci-hcd xhci-hcd.1.auto: USB bus 3 deregistered
[ 22.647421] xhci-hcd xhci-hcd.0.auto: remove, state 1
[ 22.652910] usb usb2: USB disconnect, device number 1
[ 22.659219] xhci-hcd xhci-hcd.0.auto: USB bus 2 deregistered
[ 22.662768] xhci-hcd xhci-hcd.0.auto: remove, state 1
[ 22.668604] usb usb1: USB disconnect, device number 1
[ 22.674803] xhci-hcd xhci-hcd.0.auto: USB bus 1 deregistered
root@LEDE:/# modprobe dwc3
[ 25.404592] xhci-hcd xhci-hcd.0.auto: xHCI Host Controller
[ 25.404694] xhci-hcd xhci-hcd.0.auto: new USB bus registered, assigned bus number 1
[ 25.409444] xhci-hcd xhci-hcd.0.auto: hcc params 0x0228f065 hci version 0x100 quirks 0x00010010
[ 25.416589] xhci-hcd xhci-hcd.0.auto: irq 168, io mem 0x10000000
[ 25.426509] hub 1-0:1.0: USB hub found
[ 25.431626] hub 1-0:1.0: 1 port detected
[ 25.435472] xhci-hcd xhci-hcd.0.auto: xHCI Host Controller
[ 25.439206] xhci-hcd xhci-hcd.0.auto: new USB bus registered, assigned bus number 2
[ 25.444573] usb usb2: We don't know the algorithms for LPM for this host, disabling LPM.
[ 25.452926] hub 2-0:1.0: USB hub found
[ 25.460420] hub 2-0:1.0: 1 port detected
[ 25.525037] xhci-hcd xhci-hcd.1.auto: xHCI Host Controller
[ 25.525099] xhci-hcd xhci-hcd.1.auto: new USB bus registered, assigned bus number 3
[ 25.529750] xhci-hcd xhci-hcd.1.auto: hcc params 0x0228f065 hci version 0x100 quirks 0x00010010
[ 25.537002] xhci-hcd xhci-hcd.1.auto: irq 169, io mem 0x11000000
[ 25.546583] hub 3-0:1.0: USB hub found
[ 25.551997] hub 3-0:1.0: 1 port detected
[ 25.555734] xhci-hcd xhci-hcd.1.auto: xHCI Host Controller
[ 25.559621] xhci-hcd xhci-hcd.1.auto: new USB bus registered, assigned bus number 4
[ 25.564942] usb usb4: We don't know the algorithms for LPM for this host, disabling LPM.
[ 25.573063] hub 4-0:1.0: USB hub found
[ 25.580842] hub 4-0:1.0: 1 port detected
root@LEDE:/#
Fixes: dwc3 module unloading
Signed-off-by: Thomas Reifferscheid <thomas@reifferscheid.org>
2017-03-27 21:52:06 +00:00
|
|
|
+ SSUSB_CTRL_TEST_POWERDOWN, 0x0);
|
2017-03-13 12:30:10 +00:00
|
|
|
+
|
|
|
|
+ return 0;
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
+static const struct qcom_dwc3_phy_drvdata qcom_dwc3_hs_drvdata = {
|
|
|
|
+ .ops = {
|
|
|
|
+ .init = qcom_dwc3_hs_phy_init,
|
|
|
|
+ .power_on = qcom_dwc3_phy_power_on,
|
|
|
|
+ .power_off = qcom_dwc3_phy_power_off,
|
|
|
|
+ .owner = THIS_MODULE,
|
|
|
|
+ },
|
|
|
|
+ .clk_rate = 60000000,
|
|
|
|
+};
|
|
|
|
+
|
|
|
|
+static const struct qcom_dwc3_phy_drvdata qcom_dwc3_ss_drvdata = {
|
|
|
|
+ .ops = {
|
|
|
|
+ .init = qcom_dwc3_ss_phy_init,
|
|
|
|
+ .exit = qcom_dwc3_ss_phy_exit,
|
|
|
|
+ .power_on = qcom_dwc3_phy_power_on,
|
|
|
|
+ .power_off = qcom_dwc3_phy_power_off,
|
|
|
|
+ .owner = THIS_MODULE,
|
|
|
|
+ },
|
|
|
|
+ .clk_rate = 125000000,
|
|
|
|
+};
|
|
|
|
+
|
|
|
|
+static const struct of_device_id qcom_dwc3_phy_table[] = {
|
|
|
|
+ { .compatible = "qcom,dwc3-hs-usb-phy", .data = &qcom_dwc3_hs_drvdata },
|
|
|
|
+ { .compatible = "qcom,dwc3-ss-usb-phy", .data = &qcom_dwc3_ss_drvdata },
|
|
|
|
+ { /* Sentinel */ }
|
|
|
|
+};
|
|
|
|
+MODULE_DEVICE_TABLE(of, qcom_dwc3_phy_table);
|
|
|
|
+
|
|
|
|
+static int qcom_dwc3_phy_probe(struct platform_device *pdev)
|
|
|
|
+{
|
|
|
|
+ struct qcom_dwc3_usb_phy *phy_dwc3;
|
|
|
|
+ struct phy_provider *phy_provider;
|
|
|
|
+ struct phy *generic_phy;
|
|
|
|
+ struct resource *res;
|
|
|
|
+ const struct of_device_id *match;
|
|
|
|
+ const struct qcom_dwc3_phy_drvdata *data;
|
|
|
|
+
|
|
|
|
+ phy_dwc3 = devm_kzalloc(&pdev->dev, sizeof(*phy_dwc3), GFP_KERNEL);
|
|
|
|
+ if (!phy_dwc3)
|
|
|
|
+ return -ENOMEM;
|
|
|
|
+
|
|
|
|
+ match = of_match_node(qcom_dwc3_phy_table, pdev->dev.of_node);
|
|
|
|
+ data = match->data;
|
|
|
|
+
|
|
|
|
+ phy_dwc3->dev = &pdev->dev;
|
|
|
|
+
|
|
|
|
+ res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
|
|
|
+ phy_dwc3->base = devm_ioremap_resource(phy_dwc3->dev, res);
|
|
|
|
+ if (IS_ERR(phy_dwc3->base))
|
|
|
|
+ return PTR_ERR(phy_dwc3->base);
|
|
|
|
+
|
|
|
|
+ phy_dwc3->ref_clk = devm_clk_get(phy_dwc3->dev, "ref");
|
|
|
|
+ if (IS_ERR(phy_dwc3->ref_clk)) {
|
|
|
|
+ dev_dbg(phy_dwc3->dev, "cannot get reference clock\n");
|
|
|
|
+ return PTR_ERR(phy_dwc3->ref_clk);
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ clk_set_rate(phy_dwc3->ref_clk, data->clk_rate);
|
|
|
|
+
|
|
|
|
+ phy_dwc3->xo_clk = devm_clk_get(phy_dwc3->dev, "xo");
|
|
|
|
+ if (IS_ERR(phy_dwc3->xo_clk)) {
|
|
|
|
+ dev_dbg(phy_dwc3->dev, "cannot get TCXO clock\n");
|
|
|
|
+ phy_dwc3->xo_clk = NULL;
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ generic_phy = devm_phy_create(phy_dwc3->dev, pdev->dev.of_node,
|
|
|
|
+ &data->ops);
|
|
|
|
+
|
|
|
|
+ if (IS_ERR(generic_phy))
|
|
|
|
+ return PTR_ERR(generic_phy);
|
|
|
|
+
|
|
|
|
+ phy_set_drvdata(generic_phy, phy_dwc3);
|
|
|
|
+ platform_set_drvdata(pdev, phy_dwc3);
|
|
|
|
+
|
|
|
|
+ phy_provider = devm_of_phy_provider_register(phy_dwc3->dev,
|
|
|
|
+ of_phy_simple_xlate);
|
|
|
|
+
|
|
|
|
+ if (IS_ERR(phy_provider))
|
|
|
|
+ return PTR_ERR(phy_provider);
|
|
|
|
+
|
|
|
|
+ return 0;
|
|
|
|
+}
|
|
|
|
+
|
|
|
|
+static struct platform_driver qcom_dwc3_phy_driver = {
|
|
|
|
+ .probe = qcom_dwc3_phy_probe,
|
|
|
|
+ .driver = {
|
|
|
|
+ .name = "qcom-dwc3-usb-phy",
|
|
|
|
+ .owner = THIS_MODULE,
|
|
|
|
+ .of_match_table = qcom_dwc3_phy_table,
|
|
|
|
+ },
|
|
|
|
+};
|
|
|
|
+
|
|
|
|
+module_platform_driver(qcom_dwc3_phy_driver);
|
|
|
|
+
|
|
|
|
+MODULE_ALIAS("platform:phy-qcom-dwc3");
|
|
|
|
+MODULE_LICENSE("GPL v2");
|
|
|
|
+MODULE_AUTHOR("Andy Gross <agross@codeaurora.org>");
|
|
|
|
+MODULE_AUTHOR("Ivan T. Ivanov <iivanov@mm-sol.com>");
|
|
|
|
+MODULE_DESCRIPTION("DesignWare USB3 QCOM PHY driver");
|