2016-04-01 07:11:18 +00:00
|
|
|
From c657573d75d71076fef8294f9d4f7f9a0e6f7a9e Mon Sep 17 00:00:00 2001
|
2016-03-22 21:14:51 +00:00
|
|
|
From: Dan Carpenter <dan.carpenter@oracle.com>
|
|
|
|
|
Date: Tue, 15 Mar 2016 10:18:49 +0300
|
2016-04-09 10:25:08 +00:00
|
|
|
Subject: [PATCH 60/81] net: mediatek: checking for IS_ERR() instead of NULL
|
2016-03-22 21:14:51 +00:00
|
|
|
|
|
|
|
|
of_phy_connect() returns NULL on error, it never returns error pointers.
|
|
|
|
|
|
|
|
|
|
Fixes: 656e705243fd ('net-next: mediatek: add support for MT7623 ethernet')
|
|
|
|
|
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
|
|
|
|
|
---
|
|
|
|
|
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 4 ++--
|
|
|
|
|
1 file changed, 2 insertions(+), 2 deletions(-)
|
|
|
|
|
|
|
|
|
|
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
|
|
|
|
|
index ba3afa5..9759fe5 100644
|
|
|
|
|
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
|
|
|
|
|
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
|
|
|
|
|
@@ -186,9 +186,9 @@ static int mtk_phy_connect_node(struct mtk_eth *eth, struct mtk_mac *mac,
|
|
|
|
|
|
|
|
|
|
phydev = of_phy_connect(eth->netdev[mac->id], phy_node,
|
|
|
|
|
mtk_phy_link_adjust, 0, phy_mode);
|
|
|
|
|
- if (IS_ERR(phydev)) {
|
|
|
|
|
+ if (!phydev) {
|
|
|
|
|
dev_err(eth->dev, "could not connect to PHY\n");
|
|
|
|
|
- return PTR_ERR(phydev);
|
|
|
|
|
+ return -ENODEV;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
dev_info(eth->dev,
|
|
|
|
|
--
|
|
|
|
|
1.7.10.4
|
|
|
|
|
|
