745d0e7f4b
print_int used 'int' type internally, whereas print_uint used 'uint64_t' These helper functions eventually call vfprintf(fp, fmt, args) which is a variable argument list function and is dependent upon 'fmt' containing correct information about the length of the passed arguments. Unfortunately print_int v print_uint offered no clue to the programmer that internally passed ints to print_uint were being promoted to 64bits, thus the format passed in 'fmt' string vs the actual passed integer could be different lengths. This is even more interesting on big endian architectures where 'vfprintf' would be looking in the middle of an int64 type. Symptoms of this included tc qdisc showing bizarre values for a variety of fields across a variety of qdiscs (e.g. refcnt, flows, quantum) print_u/int now stick with native int size. A similar patch has been sent upstream. Fixes FS#1425 Signed-off-by: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk> |
||
|---|---|---|
| .. | ||
| 001-config.patch | ||
| 004-darwin_fixes.patch | ||
| 007-no_arpd.patch | ||
| 008-no_netem.patch | ||
| 009-keep_libmnl_optional.patch | ||
| 100-allow_pfifo_fast.patch | ||
| 110-extra-ccopts.patch | ||
| 120-libnetlink-pic.patch | ||
| 300-ip_tiny.patch | ||
| 900-drop_FAILED_POLICY.patch | ||
| 910-iproute2-fix-hidden-uint-to-uin64_t-promottion-in-js.patch | ||
| 950-add-cake-to-tc.patch | ||