KumiSystems/openwrtv3
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

ledtrig-netdev: add support for renamed devices

Browse source 
The ppp0 interface is renamed after the connection is established. Due
to a missing NETDEV_REGISTER event, the ledtrig-netdev isn't aware of
the renamed interface and literally ignores the device
(no tx/rx indication, led isn't switched off with 'ifdown wan').

Signed-off-by: Mathias Kresin <openwrt@kresin.me>

SVN-Revision: 48048
This commit is contained in:
John Crispin 2016-01-01 21:19:41 +00:00
parent 6f95d749d6
commit df165974c3
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
target/linux/generic/files/drivers/leds/ledtrig-netdev.c
View file

@ -265,7 +265,7 @@ static int netdev_trig_notify(struct notifier_block *nb,
struct net_device *dev = netdev_notifier_info_to_dev((struct netdev_notifier_info *) dv); struct net_device *dev = netdev_notifier_info_to_dev((struct netdev_notifier_info *) dv);
struct led_netdev_data *trigger_data = container_of(nb, struct led_netdev_data, notifier); struct led_netdev_data *trigger_data = container_of(nb, struct led_netdev_data, notifier);
if (evt != NETDEV_UP && evt != NETDEV_DOWN && evt != NETDEV_CHANGE && evt != NETDEV_REGISTER && evt != NETDEV_UNREGISTER) if (evt != NETDEV_UP && evt != NETDEV_DOWN && evt != NETDEV_CHANGE && evt != NETDEV_REGISTER && evt != NETDEV_UNREGISTER && evt != NETDEV_CHANGENAME)
return NOTIFY_DONE; return NOTIFY_DONE;
spin_lock_bh(&trigger_data->lock); spin_lock_bh(&trigger_data->lock);
@ -274,9 +274,10 @@ static int netdev_trig_notify(struct notifier_block *nb,
if (strcmp(dev->name, trigger_data->device_name)) if (strcmp(dev->name, trigger_data->device_name))
goto done; goto done;
if (evt == NETDEV_REGISTER) { if (evt == NETDEV_REGISTER || evt == NETDEV_CHANGENAME) {
if (trigger_data->net_dev != NULL) if (trigger_data->net_dev != NULL)
dev_put(trigger_data->net_dev); dev_put(trigger_data->net_dev);
dev_hold(dev); dev_hold(dev);
trigger_data->net_dev = dev; trigger_data->net_dev = dev;
trigger_data->link_up = 0; trigger_data->link_up = 0;