KumiSystems/openwrtv3
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

ath79: add syscon compatible property to ar7100 ethernet nodes

Browse source 
This adds "syscon" to the compatible properties for the eth0/eth1 nodes
in ar7100.dtsi.

Without this, a kernel panic is encountered on boot with some ar7100
boards. This for some reason wasn't an issue for the WNDR3800, which
uses a Realtek switch chipset, but the panic was encountered on the
RouterStation Pro (using an AR8216 switch) and some other boards that
haven't yet been merged.

The panic message mentions an unaligned access and happens in
ag71xx_mdio_probe in drivers/net/ethernet/atheros/ag71xx/ag71xx_mdio.c.

Even if the unaligned access is fixed, the ag71xx_mdio probe still fails
without the "syscon" property.

This was already being worked around in
ar7161_ubnt_routerstation-pro.dts by overriding the compatible property,
so this commit removes that as well.

All of the other ath79 .dtsi already have this property, so no changes
are needed elsewhere.

Signed-off-by: Matt Merhar <mattmerhar@protonmail.com>
This commit is contained in:
Matt Merhar 2018-08-29 20:14:19 -04:00 committed by Mathias Kresin
parent 287b7aa583
commit b672550b32
2 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
target/linux/ath79/dts/ar7100.dtsi
View file

@ -182,7 +182,7 @@
}; };
&eth0 { &eth0 {
compatible = "qca,ar7100-eth"; compatible = "qca,ar7100-eth", "syscon";
reg = <0x19000000 0x200 reg = <0x19000000 0x200
0x18070000 0x4>; 0x18070000 0x4>;
@ -201,7 +201,7 @@
}; };
&eth1 { &eth1 {
compatible = "qca,ar7100-eth"; compatible = "qca,ar7100-eth", "syscon";
reg = <0x1a000000 0x200 reg = <0x1a000000 0x200
0x18070004 0x4>; 0x18070004 0x4>;

2
target/linux/ath79/dts/ar7161_ubnt_routerstation-pro.dts
View file

@ -21,13 +21,11 @@
}; };
&eth0 { &eth0 {
compatible = "qca,ar7100-eth", "syscon";
phy-mode = "rgmii"; phy-mode = "rgmii";
phy-handle = <&phy4>; phy-handle = <&phy4>;
}; };
&eth1 { &eth1 {
compatible = "qca,ar7100-eth", "syscon";
phy-mode = "rgmii"; phy-mode = "rgmii";
phy-handle = <&phy0>; phy-handle = <&phy0>;
}; };