KumiSystems/openwrtv3
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

netifd: drop conflicting 'device' interface property

Browse source 
Do not set device runtime property on interfaces in the hotplug handler
and in fixup_interfaces(). This property conflicts with device option
in several proto handlers (mainly QMI and other WWAN/3G protos) and does
not seem to be used anywhere.

Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
Signed-off-by: Hans Dedecker <dedeckeh@gmail.com> [PKG_RELEASE increase]
This commit is contained in:
Ivan Shapovalov 2018-05-14 00:05:43 +03:00 committed by Hans Dedecker
parent 0777a3e773
commit 91b5b2e20d
3 changed files with 1 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
package/network/config/netifd/Makefile
View file

@ -1,7 +1,7 @@
include $(TOPDIR)/rules.mk include $(TOPDIR)/rules.mk
PKG_NAME:=netifd PKG_NAME:=netifd
PKG_RELEASE:=1 PKG_RELEASE:=2
PKG_SOURCE_PROTO:=git PKG_SOURCE_PROTO:=git
PKG_SOURCE_URL=$(PROJECT_GIT)/project/netifd.git PKG_SOURCE_URL=$(PROJECT_GIT)/project/netifd.git

1
package/network/config/netifd/files/etc/hotplug.d/iface/00-netstate
View file

@ -1,7 +1,6 @@
[ ifup = "$ACTION" ] && { [ ifup = "$ACTION" ] && {
uci_toggle_state network "$INTERFACE" up 1 uci_toggle_state network "$INTERFACE" up 1
[ -n "$DEVICE" ] && { [ -n "$DEVICE" ] && {
uci_toggle_state network "$INTERFACE" device "$(uci -q get network.$INTERFACE.ifname)"
uci_toggle_state network "$INTERFACE" ifname "$DEVICE" uci_toggle_state network "$INTERFACE" ifname "$DEVICE"
} }
} }

3
package/network/config/netifd/files/lib/network/config.sh
View file

@ -41,15 +41,12 @@ fixup_interface() {
config_get type "$config" type config_get type "$config" type
config_get ifname "$config" ifname config_get ifname "$config" ifname
config_get device "$config" device "$ifname"
[ "bridge" = "$type" ] && ifname="br-$config" [ "bridge" = "$type" ] && ifname="br-$config"
config_set "$config" device "$ifname"
ubus_call "network.interface.$config" status || return 0 ubus_call "network.interface.$config" status || return 0
json_get_var l3dev l3_device json_get_var l3dev l3_device
[ -n "$l3dev" ] && ifname="$l3dev" [ -n "$l3dev" ] && ifname="$l3dev"
json_init json_init
config_set "$config" ifname "$ifname" config_set "$config" ifname "$ifname"
config_set "$config" device "$device"
} }
scan_interfaces() { scan_interfaces() {