KumiSystems/openwrtv3
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Make the architecture gpio more readable

Browse source 
SVN-Revision: 8504
This commit is contained in:
Florian Fainelli 2007-08-27 10:36:29 +00:00
parent aa5fa29235
commit 6b3f2ca7de
1 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
target/linux/rdc-2.6/files/arch/i386/mach-rdc/gpio.c
View file

@ -15,8 +15,12 @@
#include <linux/module.h> #include <linux/module.h>
#include <linux/delay.h> #include <linux/delay.h>
#define RDC3210_CFGREG_ADDR 0x0CF8 #include <asm/mach-rdc/rdc321x_defs.h>
#define RDC3210_CFGREG_DATA 0x0CFC
static inline int rdc_gpio_is_valid(unsigned gpio)
{
return ((gpio > RDC_MAX_GPIO) ? 0 : 1);
}
static unsigned int rdc_gpio_read(unsigned gpio) static unsigned int rdc_gpio_read(unsigned gpio)
{ {
@ -47,7 +51,8 @@ static void rdc_gpio_write(unsigned int val)
int rdc_gpio_get_value(unsigned gpio) int rdc_gpio_get_value(unsigned gpio)
{ {
return (gpio>0x3A?-EINVAL:(int)rdc_gpio_read(gpio)); if (rdc_gpio_is_valid(gpio))
return (int)rdc_gpio_read(gpio);
} }
EXPORT_SYMBOL(rdc_gpio_get_value); EXPORT_SYMBOL(rdc_gpio_get_value);
@ -55,7 +60,9 @@ void rdc_gpio_set_value(unsigned gpio, int value)
{ {
unsigned int val; unsigned int val;
if (gpio > 0x3A) return; if (!rdc_gpio_is_valid(gpio))
return;
val = rdc_gpio_read(gpio); val = rdc_gpio_read(gpio);
if (value) if (value)