KumiSystems/openwrtv3
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

kernel: gpio-button-hotplug: Add missing ONESHOT flag to threaded IRQ request

Browse source 
Without the IRQF_ONESHOT flag in devm_request_threaded_irq() call I get
following error:

  genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq 56
  gpio-keys gpio-keys: failed to request irq:56 for gpio:20

>From kernel/irq/manage.c:

 The interrupt was requested with handler = NULL, so we use the default
 primary handler for it. But it does not have the oneshot flag set. In
 combination with level interrupts this is deadly, because the default
 primary handler just wakes the thread, then the irq lines is reenabled,
 but the device still has the level irq asserted. Rinse and repeat....

 While this works for edge type interrupts, we play it safe and reject
 unconditionally because we can't say for sure which type this interrupt
 really has. The type flags are unreliable as the underlying chip
 implementation can override them.

Signed-off-by: Petr Štetiar <ynezz@true.cz>

SVN-Revision: 48894
This commit is contained in:
John Crispin 2016-03-03 20:24:47 +00:00
parent e4dc6acd31
commit 4ac3411f09
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
package/kernel/gpio-button-hotplug/Makefile
View file

@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk
include $(INCLUDE_DIR)/kernel.mk include $(INCLUDE_DIR)/kernel.mk
PKG_NAME:=gpio-button-hotplug PKG_NAME:=gpio-button-hotplug
PKG_RELEASE:=1 PKG_RELEASE:=2
include $(INCLUDE_DIR)/package.mk include $(INCLUDE_DIR)/package.mk

2
package/kernel/gpio-button-hotplug/src/gpio-button-hotplug.c
View file

@ -563,7 +563,7 @@ static int gpio_keys_probe(struct platform_device *pdev)
} }
ret = devm_request_threaded_irq(&pdev->dev, button->irq, NULL, button_handle_irq, ret = devm_request_threaded_irq(&pdev->dev, button->irq, NULL, button_handle_irq,
IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING, IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
dev_name(&pdev->dev), bdata); dev_name(&pdev->dev), bdata);
if (ret < 0) if (ret < 0)
dev_err(&pdev->dev, "failed to request irq:%d for gpio:%d\n", button->irq, button->gpio); dev_err(&pdev->dev, "failed to request irq:%d for gpio:%d\n", button->irq, button->gpio);