ar8216: after a switch reset poll until BCMR_RESET is cleared

Currently there is a fixed 1000ms wait time after the switch was reset.
Most if not all switches need much less time to perform a reset.
Therefore replace the fixed wait time with polling for BMCR_RESET to
be cleared.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Felix Fietkau <nbd@openwrt.org>

SVN-Revision: 43329
This commit is contained in:
Felix Fietkau 2014-11-19 20:17:37 +00:00
parent 6dcdc2bb05
commit 37fefea79b

View file

@ -316,6 +316,31 @@ split_addr(u32 regaddr, u16 *r1, u16 *r2, u16 *page)
*page = regaddr & 0x1ff; *page = regaddr & 0x1ff;
} }
/* inspired by phy_poll_reset in drivers/net/phy/phy_device.c */
static int
ar8xxx_phy_poll_reset(struct mii_bus *bus)
{
unsigned int sleep_msecs = 20;
int ret, elapsed, i;
for (elapsed = sleep_msecs; elapsed <= 600;
elapsed += sleep_msecs) {
msleep(sleep_msecs);
for (i = 0; i < AR8XXX_NUM_PHYS; i++) {
ret = mdiobus_read(bus, i, MII_BMCR);
if (ret < 0)
return ret;
if (ret & BMCR_RESET)
break;
if (i == AR8XXX_NUM_PHYS - 1) {
usleep_range(1000, 2000);
return 0;
}
}
}
return -ETIMEDOUT;
}
static u32 static u32
ar8xxx_mii_read(struct ar8xxx_priv *priv, int reg) ar8xxx_mii_read(struct ar8xxx_priv *priv, int reg)
{ {
@ -876,7 +901,8 @@ ar8236_hw_init(struct ar8xxx_priv *priv)
ADVERTISE_PAUSE_ASYM); ADVERTISE_PAUSE_ASYM);
mdiobus_write(bus, i, MII_BMCR, BMCR_RESET | BMCR_ANENABLE); mdiobus_write(bus, i, MII_BMCR, BMCR_RESET | BMCR_ANENABLE);
} }
msleep(1000);
ar8xxx_phy_poll_reset(bus);
priv->initialized = true; priv->initialized = true;
return 0; return 0;
@ -964,7 +990,7 @@ ar8316_hw_init(struct ar8xxx_priv *priv)
mdiobus_write(bus, i, MII_BMCR, BMCR_RESET | BMCR_ANENABLE); mdiobus_write(bus, i, MII_BMCR, BMCR_RESET | BMCR_ANENABLE);
} }
msleep(1000); ar8xxx_phy_poll_reset(bus);
out: out:
priv->initialized = true; priv->initialized = true;
@ -1622,7 +1648,7 @@ ar8327_hw_init(struct ar8xxx_priv *priv)
mdiobus_write(bus, i, MII_BMCR, BMCR_RESET | BMCR_ANENABLE); mdiobus_write(bus, i, MII_BMCR, BMCR_RESET | BMCR_ANENABLE);
} }
msleep(1000); ar8xxx_phy_poll_reset(bus);
return 0; return 0;
} }