KumiSystems/openwrtv3
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

swconfig: release switch in error path of swconfig_get_attr

Browse source 
Signed-off-by: Karl Beldan <karl.beldan@sagemcom.com>

SVN-Revision: 21779
This commit is contained in:
Gabor Juhos 2010-06-13 11:37:32 +00:00
parent 3c10fdc725
commit 3165ea7886
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
target/linux/generic-2.6/files/drivers/net/phy/swconfig.c
View file

@ -688,7 +688,7 @@ swconfig_get_attr(struct sk_buff *skb, struct genl_info *info)
memset(&val, 0, sizeof(val));
attr = swconfig_lookup_attr(dev, info, &val);
if (!attr || !attr->get)
goto error_dev;
goto error;
if (attr->type == SWITCH_TYPE_PORTS) {
val.value.ports = dev->portbuf;
@ -737,9 +737,8 @@ swconfig_get_attr(struct sk_buff *skb, struct genl_info *info)
nla_put_failure:
if (msg)
nlmsg_free(msg);
error_dev:
swconfig_put_dev(dev);
error:
swconfig_put_dev(dev);
if (!err)
err = -ENOMEM;
return err;